To: sdl@libsdl.org From: Christian Walther <cwalther@gmx.ch> Date: Wed, 28 Dec 2005 12:13:20 +0100 Subject: [SDL] Fix for opening documents on Mac OS X < 10.4 The current code in SDLMain.m that transforms documents opened from the Finder into command-line arguments (introduced in revision 1.14, 2005-08-11) uses the methods -[NSString lengthOfBytesUsingEncoding:] and -[NSString getCString:maxLength:encoding:], which are only available in Mac OS X 10.4. Compiling this code on 10.3 produces warnings, and running it (i.e. starting an SDL application by opening a document) leads to weird behavior which I didn't investigate in detail ("*** -[NSCFString lengthOfBytesUsingEncoding:]: selector not recognized" is printed to the console log, and the SDL window never opens). The attached patch removes the offending calls and uses -[NSString UTF8String] instead, which is available everywhere. Tested on 10.3.9, and I see no reason why it shouldn't also work on 10.2 and 10.4. Two further comments: * The comment above the -[SDLMain application: openFile:] implementation says "You need to have a CFBundleDocumentsType section in your Info.plist to get this message, apparently." This is not the case in my experience - it worked just fine with a hand-built bare-bones application consisting only of Test.app/Contents/MacOS/test, without any Info.plist (although you have to press the option and command keys for such an application to accept a dragged file). * I took the liberty of cleaning up another area of SDLMain.m: I changed "CustomApplicationMain (argc, argv)" to "CustomApplicationMain (int argc, char **argv)". This avoids the "type of `argv' defaults to `int'" warnings, and I'm not sure if leaving out the types could cause problems on platforms where an int and a char** aren't of the same size. -Christian

## Makefile.am for the main SDL library

# These are the subdirectories that are always built
CORE_SUBDIRS =			\
	main

# These are the subdirectories which may be built
EXTRA_SUBDIRS =			\
	 audio video events joystick cdrom thread timer endian file cpuinfo hermes

# These are the subdirectories which will be built now
SUBDIRS = $(CORE_SUBDIRS) @SDL_EXTRADIRS@

# These are the subdirectories which will be distributed with "make dist"
DIST_SUBDIRS = $(CORE_SUBDIRS) $(EXTRA_SUBDIRS)

# The SDL library target
lib_LTLIBRARIES = libSDL.la

libSDL_la_SOURCES = $(GENERAL_SRCS)
libSDL_la_LDFLAGS = 		\
	-no-undefined		\
        -release $(LT_RELEASE)	\
	-version-info $(LT_CURRENT):$(LT_REVISION):$(LT_AGE)
libSDL_la_LIBADD =		\
	main/libarch.la		\
	@SDL_EXTRALIBS@		\
	@SYSTEM_LIBS@
libSDL_la_DEPENDENCIES =	\
	main/libarch.la		\
	@SDL_EXTRALIBS@

# The SDL library sources
GENERAL_SRCS = 		\
	SDL.c			\
	SDL_error.c		\
	SDL_error_c.h		\
	SDL_fatal.c		\
	SDL_fatal.h		\
	SDL_getenv.c		\
	SDL_loadso.c