view src/video/photon/SDL_ph_video.h @ 1287:15a89a0c52bf

Date: Tue, 15 Feb 2005 21:28:48 +0900 (JST) From: "Michael Leonhard" Subject: [SDL] resize bug on Win32 and patch This is my first post to this mailing list. In this email I will detail a bug in the behavior of resizable SDL windows on Win32. Then I will explain the solution and provide a patch. Symptoms: Under Windows, an SDL display created with the SDL_RESIZABLE flag exhibits quirky behavior when being maximized. The window is resized to the proper size, but it is shifted upwards about half the height of the title bar. Similarly, a window whose origin is above the top of the screen will spontaneously move its upper-left origin upon being resized. After two such resize-induced moves, the title bar will be entirely off the top edge of the screen. Subsequently, when the mouse is clicked and released on the window border, the window will shrink its height spontaneously. This height shrinkage occurs even if the user did not resize the border. To observe this curious situation, please invoke: SDL-1.2.8/test/testwm.exe -resize Cause: A pair of integers, SDL_windowX and SDL_windowY, are defined in video/wincommon/SDL_sysevents.c. They are used by the DirectX video driver and the DIB video driver: video/windx5/SDL_dx5video.c video/windib/SDL_dibvideo.c As I understand the source code, the primary use of these variables is to create a rectangle that represents the surface area in CLIENT SPACE. Client space refers to a coordinate system that originates at the upper left corner of a Win32 Window's drawable area. This is just inside the window border and title bar. This client space rectangle, called bounds, is subsequently converted to screen space with a call to AdjustWindowRectEx. The problem is found in SDL's handling of the WM_WINDOWPOSCHANGED message. According to MSDN, "The WM_WINDOWPOSCHANGED message is sent to a window whose size, position, or place in the Z order has changed as a result of a call to the SetWindowPos function or another window-management function." I have confirmed that this message is indeed being sent to the SDL window when the mouse is clicked on the window border, even if the window border is not dragged. In video/wincommon/SDL_sysevents.c, on line 464, in response to the WM_WINDOWPOSCHANGED message, the (potentially) new client rectangle is obtained. This rectangle is translated into screen coordinates and THEN assigned to the SDL_windowX and Y variables. Thus screen coordinates are being assigned to client coordinate variables. Once this is understood, the solution is apparent: assign SDL_windowX and Y before translating the rectangle to screen coordinates. This is accomplished by the following patch. -Mike_L
author Sam Lantinga <slouken@libsdl.org>
date Sun, 29 Jan 2006 08:50:06 +0000
parents 4ab6d1fd028f
children 19418e4422cb
line wrap: on
line source

/*
    SDL - Simple DirectMedia Layer
    Copyright (C) 1997-2004 Sam Lantinga

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
    License as published by the Free Software Foundation; either
    version 2 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Library General Public License for more details.

    You should have received a copy of the GNU Library General Public
    License along with this library; if not, write to the Free
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

    Sam Lantinga
    slouken@libsdl.org
*/

#ifndef __SDL_PH_VIDEO_H__
#define __SDL_PH_VIDEO_H__

#include "SDL_mouse.h"
#include "SDL_sysvideo.h"

#include <sys/neutrino.h>

#include <Ph.h>
#include <Pt.h>
#include <photon/Pg.h>
#include <photon/PdDirect.h>

#ifdef HAVE_OPENGL
    #if (_NTO_VERSION < 630)
        #include <photon/PdGL.h>
    #else
        #include <GL/qnxgl.h>
        #include <GL/GLPh.h>
    #endif /* 6.3.0 */
#endif /* HAVE_OPENGL */

/* Hidden "this" pointer for the video functions */
#define _THIS	SDL_VideoDevice* this

#define PH_OGL_MAX_ATTRIBS 32

#define SDLPH_PAL_NONE    0x00000000L
#define SDLPH_PAL_EMULATE 0x00000001L
#define SDLPH_PAL_SYSTEM  0x00000002L

typedef struct
{
    unsigned char* Y;
    unsigned char* V;
    unsigned char* U;
} FRAMEDATA;

/* Mask values for SDL_ReallocFormat() */
struct ColourMasks
{
    Uint32 red;
    Uint32 green;
    Uint32 blue;
    Uint32 alpha;
    Uint32 bpp;
};

/* Private display data */
struct SDL_PrivateVideoData
{
    PgDisplaySettings_t mode_settings;	
    PtWidget_t *Window;                  /* used to handle input events */
    PhImage_t *image;	                 /* used to display image       */
#ifdef HAVE_OPENGL
    #if (_NTO_VERSION < 630)
        PdOpenGLContext_t* OGLContext;   /* OpenGL context              */
        void* OGLBuffers;                /* OpenGL buffers (unused)     */
    #else
        qnxglc_t* OGLContext;            /* OpenGL context for the 6.3  */
        qnxgl_bufs_t* OGLBuffers;        /* OpenGL buffers for the 6.3  */
    #endif /* 630 */

    Uint32 OGLFlags;                     /* OpenGL flags                */
    Uint32 OGLBPP;                       /* OpenGL bpp                  */
#endif /* HAVE_OPENGL */
    PgColor_t savedpal[_Pg_MAX_PALETTE];
    PgColor_t syspalph[_Pg_MAX_PALETTE];

    struct
    {
        PdDirectContext_t*    direct_context;
        PdOffscreenContext_t* offscreen_context;
        PdOffscreenContext_t* offscreen_backcontext;
        PhDrawContext_t*      oldDC;
        uint8_t*              dc_ptr;
        unsigned char*        CurrentFrameData;
        unsigned char*        FrameData0;
        unsigned char*        FrameData1;
        Uint32                current;
        Uint32                flags;
    } ocimage;

    PgHWCaps_t graphics_card_caps;  /* Graphics card caps at the moment of start   */
    PgVideoModeInfo_t desktop_mode; /* Current desktop video mode information      */
    int old_video_mode;             /* Stored mode before fullscreen switch        */
    int old_refresh_rate;           /* Stored refresh rate befor fullscreen switch */

    int mouse_relative;
    WMcursor* BlankCursor;
    uint32_t videomode_emulatemode;

    Uint32 visualbpp;	            /* current visual bpp                          */
    Uint32 desktopbpp;              /* bpp of desktop at the moment of start       */
    Uint32 desktoppal;              /* palette mode emulation or system            */

    int currently_fullscreen;
    int currently_hided;            /* 1 - window hided (minimazed), 0 - normal    */
    int currently_maximized;        /* 1 - window hided (minimazed), 0 - normal    */

    PhEvent_t* event;
    SDL_Overlay* overlay;
};

#define mode_settings         (this->hidden->mode_settings)
#define window	              (this->hidden->Window)
#define SDL_Image             (this->hidden->image)
#define OCImage               (this->hidden->ocimage)
#define old_video_mode        (this->hidden->old_video_mode)
#define old_refresh_rate      (this->hidden->old_refresh_rate)
#define graphics_card_caps    (this->hidden->graphics_card_caps)
#define desktopbpp            (this->hidden->desktopbpp)
#define visualbpp             (this->hidden->visualbpp)
#define desktoppal            (this->hidden->desktoppal)
#define savedpal              (this->hidden->savedpal)
#define syspalph              (this->hidden->syspalph)
#define currently_fullscreen  (this->hidden->currently_fullscreen)
#define currently_hided       (this->hidden->currently_hided)
#define currently_maximized   (this->hidden->currently_maximized)
#define event                 (this->hidden->event)
#define current_overlay       (this->hidden->overlay)
#define desktop_mode          (this->hidden->desktop_mode)
#define mouse_relative        (this->hidden->mouse_relative)
#define SDL_BlankCursor       (this->hidden->BlankCursor)
#define videomode_emulatemode (this->hidden->videomode_emulatemode)

#ifdef HAVE_OPENGL
     #define oglctx               (this->hidden->OGLContext)
     #define oglbuffers           (this->hidden->OGLBuffers)
     #define oglflags             (this->hidden->OGLFlags)
     #define oglbpp               (this->hidden->OGLBPP)
#endif /* HAVE_OPENGL */

#endif /* __SDL_PH_VIDEO_H__ */