Mercurial > sdl-ios-xcode
view src/video/gem/SDL_gemevents.c @ 1287:15a89a0c52bf
Date: Tue, 15 Feb 2005 21:28:48 +0900 (JST)
From: "Michael Leonhard"
Subject: [SDL] resize bug on Win32 and patch
This is my first post to this mailing list. In this email I will detail a
bug in the behavior of resizable SDL windows on Win32. Then I will
explain the solution and provide a patch.
Symptoms:
Under Windows, an SDL display created with the SDL_RESIZABLE flag exhibits
quirky behavior when being maximized. The window is resized to the proper
size, but it is shifted upwards about half the height of the title bar.
Similarly, a window whose origin is above the top of the screen will
spontaneously move its upper-left origin upon being resized. After two
such resize-induced moves, the title bar will be entirely off the top edge
of the screen. Subsequently, when the mouse is clicked and released on
the window border, the window will shrink its height spontaneously. This
height shrinkage occurs even if the user did not resize the border.
To observe this curious situation, please invoke:
SDL-1.2.8/test/testwm.exe -resize
Cause:
A pair of integers, SDL_windowX and SDL_windowY, are defined in
video/wincommon/SDL_sysevents.c. They are used by the DirectX video
driver and the DIB video driver:
video/windx5/SDL_dx5video.c
video/windib/SDL_dibvideo.c
As I understand the source code, the primary use of these variables is to
create a rectangle that represents the surface area in CLIENT SPACE.
Client space refers to a coordinate system that originates at the upper
left corner of a Win32 Window's drawable area. This is just inside the
window border and title bar. This client space rectangle, called bounds,
is subsequently converted to screen space with a call to
AdjustWindowRectEx. The problem is found in SDL's handling of the
WM_WINDOWPOSCHANGED message. According to MSDN,
"The WM_WINDOWPOSCHANGED message is sent to a window whose
size, position, or place in the Z order has changed as a
result of a call to the SetWindowPos function or another
window-management function."
I have confirmed that this message is indeed being sent to the SDL window
when the mouse is clicked on the window border, even if the window border
is not dragged.
In video/wincommon/SDL_sysevents.c, on line 464, in response to the
WM_WINDOWPOSCHANGED message, the (potentially) new client rectangle is
obtained. This rectangle is translated into screen coordinates and THEN
assigned to the SDL_windowX and Y variables. Thus screen coordinates are
being assigned to client coordinate variables. Once this is understood,
the solution is apparent: assign SDL_windowX and Y before translating the
rectangle to screen coordinates. This is accomplished by the following
patch.
-Mike_L
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 29 Jan 2006 08:50:06 +0000 |
parents | fdc7ef6ecab4 |
children | a201a8c62522 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif /* * GEM SDL video driver implementation * inspired from the Dummy SDL driver * * Patrice Mandin * and work from * Olivier Landemarre, Johan Klockars, Xavier Joubert, Claude Attard */ #include <string.h> #include <gem.h> #include "SDL.h" #include "SDL_sysevents.h" #include "SDL_events_c.h" #include "SDL_gemvideo.h" #include "SDL_gemevents_c.h" #include "SDL_atarikeys.h" /* for keyboard scancodes */ #include "SDL_atarievents_c.h" #include "SDL_xbiosinterrupt_s.h" /* Defines */ #define ATARIBIOS_MAXKEYS 128 /* Variables */ static unsigned char gem_currentkeyboard[ATARIBIOS_MAXKEYS]; static unsigned char gem_previouskeyboard[ATARIBIOS_MAXKEYS]; static unsigned char gem_currentascii[ATARIBIOS_MAXKEYS]; /* The translation tables from a console scancode to a SDL keysym */ static SDLKey keymap[ATARIBIOS_MAXKEYS]; /* Functions prototypes */ static SDL_keysym *TranslateKey(int scancode, int asciicode, SDL_keysym *keysym, SDL_bool pressed); static int do_messages(_THIS, short *message); static void do_keyboard(short kc, short ks); static void do_mouse(_THIS, short mx, short my, short mb, short ks); /* Functions */ static SDL_keysym *TranslateKey(int scancode, int asciicode, SDL_keysym *keysym, SDL_bool pressed) { /* Set the keysym information */ keysym->scancode = scancode; if (asciicode) keysym->sym = asciicode; else keysym->sym = keymap[scancode]; keysym->mod = KMOD_NONE; keysym->unicode = 0; if (SDL_TranslateUNICODE && pressed) { keysym->unicode = SDL_AtariToUnicodeTable[asciicode]; } return(keysym); } void GEM_InitOSKeymap(_THIS) { int i; memset(gem_currentkeyboard, 0, sizeof(gem_currentkeyboard)); memset(gem_previouskeyboard, 0, sizeof(gem_previouskeyboard)); memset(gem_currentascii, 0, sizeof(gem_currentascii)); /* Initialize keymap */ for ( i=0; i<sizeof(keymap); i++ ) keymap[i] = SDLK_UNKNOWN; /* Functions keys */ for ( i = 0; i<10; i++ ) keymap[SCANCODE_F1 + i] = SDLK_F1+i; /* Cursor keypad */ keymap[SCANCODE_HELP] = SDLK_HELP; keymap[SCANCODE_UNDO] = SDLK_UNDO; keymap[SCANCODE_INSERT] = SDLK_INSERT; keymap[SCANCODE_CLRHOME] = SDLK_HOME; keymap[SCANCODE_UP] = SDLK_UP; keymap[SCANCODE_DOWN] = SDLK_DOWN; keymap[SCANCODE_RIGHT] = SDLK_RIGHT; keymap[SCANCODE_LEFT] = SDLK_LEFT; /* Special keys */ keymap[SCANCODE_ESCAPE] = SDLK_ESCAPE; keymap[SCANCODE_BACKSPACE] = SDLK_BACKSPACE; keymap[SCANCODE_TAB] = SDLK_TAB; keymap[SCANCODE_ENTER] = SDLK_RETURN; keymap[SCANCODE_DELETE] = SDLK_DELETE; keymap[SCANCODE_LEFTCONTROL] = SDLK_LCTRL; keymap[SCANCODE_LEFTSHIFT] = SDLK_LSHIFT; keymap[SCANCODE_RIGHTSHIFT] = SDLK_RSHIFT; keymap[SCANCODE_LEFTALT] = SDLK_LALT; keymap[SCANCODE_CAPSLOCK] = SDLK_CAPSLOCK; /* Mouse init */ GEM_mouse_relative = SDL_FALSE; } void GEM_PumpEvents(_THIS) { short mousex, mousey, mouseb, dummy; short kstate, prevkc, prevks; int i; SDL_keysym keysym; memset(gem_currentkeyboard,0,sizeof(gem_currentkeyboard)); prevkc = prevks = 0; for (;;) { int quit, resultat, event_mask, mouse_event; short buffer[8], kc; short x2,y2,w2,h2; quit = mouse_event = x2=y2=w2=h2 = 0; event_mask = MU_MESAG|MU_TIMER|MU_KEYBD; if (!GEM_fullscreen && (GEM_handle>=0)) { wind_get (GEM_handle, WF_WORKXYWH, &x2, &y2, &w2, &h2); event_mask |= MU_M1; if ( (SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) { mouse_event = MO_LEAVE; } else { mouse_event = MO_ENTER; } } resultat = evnt_multi( event_mask, 0,0,0, mouse_event,x2,y2,w2,h2, 0,0,0,0,0, buffer, 10, &dummy,&dummy,&dummy,&kstate,&kc,&dummy ); /* Message event ? */ if (resultat & MU_MESAG) quit = do_messages(this, buffer); /* Keyboard event ? */ if (resultat & MU_KEYBD) { if ((prevkc != kc) || (prevks != kstate)) { do_keyboard(kc,kstate); } else { /* Avoid looping, if repeating same key */ break; } } /* Mouse entering/leaving window */ if (resultat & MU_M1) { if (this->input_grab == SDL_GRAB_OFF) { if (SDL_GetAppState() & SDL_APPMOUSEFOCUS) { SDL_PrivateAppActive(0, SDL_APPMOUSEFOCUS); } else { SDL_PrivateAppActive(1, SDL_APPMOUSEFOCUS); } } } /* Timer event ? */ if ((resultat & MU_TIMER) || quit) break; } /* Update mouse */ graf_mkstate(&mousex, &mousey, &mouseb, &kstate); do_mouse(this, mousex, mousey, mouseb, kstate); /* Now generate keyboard events */ for (i=0; i<ATARIBIOS_MAXKEYS; i++) { /* Key pressed ? */ if (gem_currentkeyboard[i] && !gem_previouskeyboard[i]) SDL_PrivateKeyboard(SDL_PRESSED, TranslateKey(i, gem_currentascii[i], &keysym, SDL_TRUE)); /* Key unpressed ? */ if (gem_previouskeyboard[i] && !gem_currentkeyboard[i]) SDL_PrivateKeyboard(SDL_RELEASED, TranslateKey(i, gem_currentascii[i], &keysym, SDL_FALSE)); } memcpy(gem_previouskeyboard,gem_currentkeyboard,sizeof(gem_previouskeyboard)); /* Refresh window name ? */ if (GEM_refresh_name) { if ( SDL_GetAppState() & SDL_APPACTIVE ) { /* Fullscreen/windowed */ if (GEM_title_name) { wind_set(GEM_handle,WF_NAME,(short)(((unsigned long)GEM_title_name)>>16),(short)(((unsigned long)GEM_title_name) & 0xffff),0,0); } } else { /* Iconified */ if (GEM_icon_name) { wind_set(GEM_handle,WF_NAME,(short)(((unsigned long)GEM_icon_name)>>16),(short)(((unsigned long)GEM_icon_name) & 0xffff),0,0); } } GEM_refresh_name = SDL_FALSE; } } static int do_messages(_THIS, short *message) { int quit, posted; short x2,y2,w2,h2; quit=0; switch (message[0]) { case WM_CLOSED: case AP_TERM: posted = SDL_PrivateQuit(); quit=1; break; case WM_MOVED: wind_set(message[3],WF_CURRXYWH,message[4],message[5],message[6],message[7]); break; case WM_TOPPED: wind_set(message[3],WF_TOP,message[4],0,0,0); /* Continue with TOP event processing */ case WM_ONTOP: SDL_PrivateAppActive(1, SDL_APPINPUTFOCUS); if (VDI_setpalette) { VDI_setpalette(this, VDI_curpalette); } break; case WM_REDRAW: if (!GEM_lock_redraw) { GEM_wind_redraw(this, message[3],&message[4]); } break; case WM_ICONIFY: case WM_ALLICONIFY: wind_set(message[3],WF_ICONIFY,message[4],message[5],message[6],message[7]); /* If we're active, make ourselves inactive */ if ( SDL_GetAppState() & SDL_APPACTIVE ) { /* Send an internal deactivate event */ SDL_PrivateAppActive(0, SDL_APPACTIVE); } /* Update window title */ if (GEM_refresh_name && GEM_icon_name) { wind_set(GEM_handle,WF_NAME,(short)(((unsigned long)GEM_icon_name)>>16),(short)(((unsigned long)GEM_icon_name) & 0xffff),0,0); GEM_refresh_name = SDL_FALSE; } break; case WM_UNICONIFY: wind_set(message[3],WF_UNICONIFY,message[4],message[5],message[6],message[7]); /* If we're not active, make ourselves active */ if ( !(SDL_GetAppState() & SDL_APPACTIVE) ) { /* Send an internal activate event */ SDL_PrivateAppActive(1, SDL_APPACTIVE); } if (GEM_refresh_name && GEM_title_name) { wind_set(GEM_handle,WF_NAME,(short)(((unsigned long)GEM_title_name)>>16),(short)(((unsigned long)GEM_title_name) & 0xffff),0,0); GEM_refresh_name = SDL_FALSE; } break; case WM_SIZED: wind_set (message[3], WF_CURRXYWH, message[4], message[5], message[6], message[7]); wind_get (message[3], WF_WORKXYWH, &x2, &y2, &w2, &h2); GEM_win_fulled = SDL_FALSE; /* Cancel maximized flag */ GEM_lock_redraw = SDL_TRUE; /* Prevent redraw till buffers resized */ SDL_PrivateResize(w2, h2); break; case WM_FULLED: { short x,y,w,h; if (GEM_win_fulled) { wind_get (message[3], WF_PREVXYWH, &x, &y, &w, &h); GEM_win_fulled = SDL_FALSE; } else { x = GEM_desk_x; y = GEM_desk_y; w = GEM_desk_w; h = GEM_desk_h; GEM_win_fulled = SDL_TRUE; } wind_set (message[3], WF_CURRXYWH, x, y, w, h); wind_get (message[3], WF_WORKXYWH, &x2, &y2, &w2, &h2); GEM_lock_redraw = SDL_TRUE; /* Prevent redraw till buffers resized */ SDL_PrivateResize(w2, h2); } break; case WM_BOTTOMED: wind_set(message[3],WF_BOTTOM,0,0,0,0); /* Continue with BOTTOM event processing */ case WM_UNTOPPED: SDL_PrivateAppActive(0, SDL_APPINPUTFOCUS); if (VDI_setpalette) { VDI_setpalette(this, VDI_oldpalette); } break; } return quit; } static void do_keyboard(short kc, short ks) { int scancode, asciicode; if (kc) { scancode=(kc>>8) & 127; asciicode=kc & 255; gem_currentkeyboard[scancode]=0xFF; gem_currentascii[scancode]=asciicode; } /* Read special keys */ if (ks & K_RSHIFT) gem_currentkeyboard[SCANCODE_RIGHTSHIFT]=0xFF; if (ks & K_LSHIFT) gem_currentkeyboard[SCANCODE_LEFTSHIFT]=0xFF; if (ks & K_CTRL) gem_currentkeyboard[SCANCODE_LEFTCONTROL]=0xFF; if (ks & K_ALT) gem_currentkeyboard[SCANCODE_LEFTALT]=0xFF; } static void do_mouse(_THIS, short mx, short my, short mb, short ks) { static short prevmousex=0, prevmousey=0, prevmouseb=0; short x2, y2, w2, h2; /* Don't return mouse events if out of window */ if ((SDL_GetAppState() & SDL_APPMOUSEFOCUS)==0) { return; } /* Retrieve window coords, and generate mouse events accordingly */ x2 = y2 = 0; w2 = VDI_w; h2 = VDI_h; if ((!GEM_fullscreen) && (GEM_handle>=0)) { wind_get (GEM_handle, WF_WORKXYWH, &x2, &y2, &w2, &h2); /* Do not generate mouse button event if out of window working area */ if ((mx<x2) || (mx>=x2+w2) || (my<y2) || (my>=y2+h2)) { mb=prevmouseb; } } /* Mouse motion ? */ if (GEM_mouse_relative) { if (SDL_AtariXbios_mousex || SDL_AtariXbios_mousey) { SDL_PrivateMouseMotion(0, 1, SDL_AtariXbios_mousex, SDL_AtariXbios_mousey); SDL_AtariXbios_mousex = SDL_AtariXbios_mousey = 0; } } else { if ((prevmousex!=mx) || (prevmousey!=my)) { int posx, posy; /* Give mouse position relative to window position */ posx = mx - x2; if (posx<0) posx = 0; if (posx>w2) posx = w2-1; posy = my - y2; if (posy<0) posy = 0; if (posy>h2) posy = h2-1; SDL_PrivateMouseMotion(0, 0, posx, posy); } prevmousex = mx; prevmousey = my; } /* Mouse button ? */ if (prevmouseb!=mb) { int i; for (i=0;i<2;i++) { int curbutton, prevbutton; curbutton = mb & (1<<i); prevbutton = prevmouseb & (1<<i); if (curbutton && !prevbutton) { SDL_PrivateMouseButton(SDL_PRESSED, i+1, 0, 0); } if (!curbutton && prevbutton) { SDL_PrivateMouseButton(SDL_RELEASED, i+1, 0, 0); } } prevmouseb = mb; } /* Read special keys */ if (ks & K_RSHIFT) gem_currentkeyboard[SCANCODE_RIGHTSHIFT]=0xFF; if (ks & K_LSHIFT) gem_currentkeyboard[SCANCODE_LEFTSHIFT]=0xFF; if (ks & K_CTRL) gem_currentkeyboard[SCANCODE_LEFTCONTROL]=0xFF; if (ks & K_ALT) gem_currentkeyboard[SCANCODE_LEFTALT]=0xFF; }