Mercurial > sdl-ios-xcode
view src/audio/SDL_sysaudio.h @ 1287:15a89a0c52bf
Date: Tue, 15 Feb 2005 21:28:48 +0900 (JST)
From: "Michael Leonhard"
Subject: [SDL] resize bug on Win32 and patch
This is my first post to this mailing list. In this email I will detail a
bug in the behavior of resizable SDL windows on Win32. Then I will
explain the solution and provide a patch.
Symptoms:
Under Windows, an SDL display created with the SDL_RESIZABLE flag exhibits
quirky behavior when being maximized. The window is resized to the proper
size, but it is shifted upwards about half the height of the title bar.
Similarly, a window whose origin is above the top of the screen will
spontaneously move its upper-left origin upon being resized. After two
such resize-induced moves, the title bar will be entirely off the top edge
of the screen. Subsequently, when the mouse is clicked and released on
the window border, the window will shrink its height spontaneously. This
height shrinkage occurs even if the user did not resize the border.
To observe this curious situation, please invoke:
SDL-1.2.8/test/testwm.exe -resize
Cause:
A pair of integers, SDL_windowX and SDL_windowY, are defined in
video/wincommon/SDL_sysevents.c. They are used by the DirectX video
driver and the DIB video driver:
video/windx5/SDL_dx5video.c
video/windib/SDL_dibvideo.c
As I understand the source code, the primary use of these variables is to
create a rectangle that represents the surface area in CLIENT SPACE.
Client space refers to a coordinate system that originates at the upper
left corner of a Win32 Window's drawable area. This is just inside the
window border and title bar. This client space rectangle, called bounds,
is subsequently converted to screen space with a call to
AdjustWindowRectEx. The problem is found in SDL's handling of the
WM_WINDOWPOSCHANGED message. According to MSDN,
"The WM_WINDOWPOSCHANGED message is sent to a window whose
size, position, or place in the Z order has changed as a
result of a call to the SetWindowPos function or another
window-management function."
I have confirmed that this message is indeed being sent to the SDL window
when the mouse is clicked on the window border, even if the window border
is not dragged.
In video/wincommon/SDL_sysevents.c, on line 464, in response to the
WM_WINDOWPOSCHANGED message, the (potentially) new client rectangle is
obtained. This rectangle is translated into screen coordinates and THEN
assigned to the SDL_windowX and Y variables. Thus screen coordinates are
being assigned to client coordinate variables. Once this is understood,
the solution is apparent: assign SDL_windowX and Y before translating the
rectangle to screen coordinates. This is accomplished by the following
patch.
-Mike_L
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Sun, 29 Jan 2006 08:50:06 +0000 |
| parents | 173c063d4f55 |
| children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif #ifndef _SDL_sysaudio_h #define _SDL_sysaudio_h #include "SDL_mutex.h" #include "SDL_thread.h" /* The SDL audio driver */ typedef struct SDL_AudioDevice SDL_AudioDevice; /* Define the SDL audio driver structure */ #define _THIS SDL_AudioDevice *_this #ifndef _STATUS #define _STATUS SDL_status *status #endif struct SDL_AudioDevice { /* * * */ /* The name of this audio driver */ const char *name; /* * * */ /* The description of this audio driver */ const char *desc; /* * * */ /* Public driver functions */ int (*OpenAudio)(_THIS, SDL_AudioSpec *spec); void (*ThreadInit)(_THIS); /* Called by audio thread at start */ void (*WaitAudio)(_THIS); void (*PlayAudio)(_THIS); Uint8 *(*GetAudioBuf)(_THIS); void (*WaitDone)(_THIS); void (*CloseAudio)(_THIS); /* * * */ /* Lock / Unlock functions added for the Mac port */ void (*LockAudio)(_THIS); void (*UnlockAudio)(_THIS); /* * * */ /* Data common to all devices */ /* The current audio specification (shared with audio thread) */ SDL_AudioSpec spec; /* An audio conversion block for audio format emulation */ SDL_AudioCVT convert; /* Current state flags */ int enabled; int paused; int opened; /* Fake audio buffer for when the audio hardware is busy */ Uint8 *fake_stream; /* A semaphore for locking the mixing buffers */ SDL_mutex *mixer_lock; /* A thread to feed the audio device */ SDL_Thread *thread; Uint32 threadid; /* * * */ /* Data private to this driver */ struct SDL_PrivateAudioData *hidden; /* * * */ /* The function used to dispose of this structure */ void (*free)(_THIS); }; #undef _THIS typedef struct AudioBootStrap { const char *name; const char *desc; int (*available)(void); SDL_AudioDevice *(*create)(int devindex); } AudioBootStrap; #ifdef OPENBSD_AUDIO_SUPPORT extern AudioBootStrap OPENBSD_AUDIO_bootstrap; #endif #ifdef OSS_SUPPORT extern AudioBootStrap DSP_bootstrap; extern AudioBootStrap DMA_bootstrap; #endif #ifdef ALSA_SUPPORT extern AudioBootStrap ALSA_bootstrap; #endif #ifdef QNXNTOAUDIO_SUPPORT extern AudioBootStrap QNXNTOAUDIO_bootstrap; #endif #ifdef SUNAUDIO_SUPPORT extern AudioBootStrap SUNAUDIO_bootstrap; #endif #ifdef DMEDIA_SUPPORT extern AudioBootStrap DMEDIA_bootstrap; #endif #ifdef ARTSC_SUPPORT extern AudioBootStrap ARTSC_bootstrap; #endif #ifdef ESD_SUPPORT extern AudioBootStrap ESD_bootstrap; #endif #ifdef NAS_SUPPORT extern AudioBootStrap NAS_bootstrap; #endif #ifdef ENABLE_DIRECTX extern AudioBootStrap DSOUND_bootstrap; #endif #ifdef ENABLE_WINDIB extern AudioBootStrap WAVEOUT_bootstrap; #endif #ifdef _AIX extern AudioBootStrap Paud_bootstrap; #endif #ifdef __BEOS__ extern AudioBootStrap BAUDIO_bootstrap; #endif #ifdef MACOSX extern AudioBootStrap COREAUDIO_bootstrap; #endif #if defined(macintosh) || TARGET_API_MAC_CARBON extern AudioBootStrap SNDMGR_bootstrap; #endif #ifdef ENABLE_AHI extern AudioBootStrap AHI_bootstrap; #endif #ifdef MINTAUDIO_SUPPORT extern AudioBootStrap MINTAUDIO_GSXB_bootstrap; extern AudioBootStrap MINTAUDIO_MCSN_bootstrap; extern AudioBootStrap MINTAUDIO_STFA_bootstrap; extern AudioBootStrap MINTAUDIO_XBIOS_bootstrap; extern AudioBootStrap MINTAUDIO_DMA8_bootstrap; #endif #ifdef DISKAUD_SUPPORT extern AudioBootStrap DISKAUD_bootstrap; #endif #ifdef ENABLE_DC extern AudioBootStrap DCAUD_bootstrap; #endif #ifdef DRENDERER_SUPPORT extern AudioBootStrap DRENDERER_bootstrap; #endif #ifdef MMEAUDIO_SUPPORT extern AudioBootStrap MMEAUDIO_bootstrap; #endif #ifdef __OS2__ extern AudioBootStrap DART_bootstrap; #endif /* This is the current audio device */ extern SDL_AudioDevice *current_audio; #endif /* _SDL_sysaudio_h */