Mercurial > sdl-ios-xcode

view BUGS @ 1287:15a89a0c52bf

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Date: Tue, 15 Feb 2005 21:28:48 +0900 (JST) From: "Michael Leonhard" Subject: [SDL] resize bug on Win32 and patch This is my first post to this mailing list. In this email I will detail a bug in the behavior of resizable SDL windows on Win32. Then I will explain the solution and provide a patch. Symptoms: Under Windows, an SDL display created with the SDL_RESIZABLE flag exhibits quirky behavior when being maximized. The window is resized to the proper size, but it is shifted upwards about half the height of the title bar. Similarly, a window whose origin is above the top of the screen will spontaneously move its upper-left origin upon being resized. After two such resize-induced moves, the title bar will be entirely off the top edge of the screen. Subsequently, when the mouse is clicked and released on the window border, the window will shrink its height spontaneously. This height shrinkage occurs even if the user did not resize the border. To observe this curious situation, please invoke: SDL-1.2.8/test/testwm.exe -resize Cause: A pair of integers, SDL_windowX and SDL_windowY, are defined in video/wincommon/SDL_sysevents.c. They are used by the DirectX video driver and the DIB video driver: video/windx5/SDL_dx5video.c video/windib/SDL_dibvideo.c As I understand the source code, the primary use of these variables is to create a rectangle that represents the surface area in CLIENT SPACE. Client space refers to a coordinate system that originates at the upper left corner of a Win32 Window's drawable area. This is just inside the window border and title bar. This client space rectangle, called bounds, is subsequently converted to screen space with a call to AdjustWindowRectEx. The problem is found in SDL's handling of the WM_WINDOWPOSCHANGED message. According to MSDN, "The WM_WINDOWPOSCHANGED message is sent to a window whose size, position, or place in the Z order has changed as a result of a call to the SetWindowPos function or another window-management function." I have confirmed that this message is indeed being sent to the SDL window when the mouse is clicked on the window border, even if the window border is not dragged. In video/wincommon/SDL_sysevents.c, on line 464, in response to the WM_WINDOWPOSCHANGED message, the (potentially) new client rectangle is obtained. This rectangle is translated into screen coordinates and THEN assigned to the SDL_windowX and Y variables. Thus screen coordinates are being assigned to client coordinate variables. Once this is understood, the solution is apparent: assign SDL_windowX and Y before translating the rectangle to screen coordinates. This is accomplished by the following patch. -Mike_L
author Sam Lantinga <slouken@libsdl.org>
date Sun, 29 Jan 2006 08:50:06 +0000
parents 9867f3d86e44
children f12379c41042
line wrap: on
line source


All:
	Audio rate conversion is only implemented by multiplying or dividing
	by a power of two.  This is a side-effect of the requirement that the
	raw audio buffer size be a power of two, and can hopefully be fixed.
	This means 8 KHz audio converted to 22 KHz ends up being 16 KHz. :-/

	When the implementation is writing directly to video memory the mouse
	cursor doesn't work properly.  Applications which do this should use
	their own mouse cursor and call SDL_ShowCursor(0) to hide the system
	cursor.

Linux:
	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed)

	The keyboard modifiers are not set to the correct state on startup.

	The AAlib, GGI, and SVGAlib video drivers are not heavily tested.

Win32:
	The MCI driver can't tell if the CD-ROM drive is paused or stopped.

	The SDL_INIT_EVENTTHREAD flag is not supported on Win32
	(Idea: create a separate DirectInput polling thread)
	The main purpose of this flag is for smooth cursor motion in
	fullscreen environments.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	This requires the ToUnicode() API which is only implemented on
	Windows NT/2000, not on Windows 95/98.
	Latin-1 keyboard input works fine.

	Joysticks are only supported under the Win32 MultiMedia API,
	DirectInput support is not yet implemented.

BeOS:
	BePPC is not supported, apparently not even by Be Inc.

	SDL_WM_GrabInput() is not implemented.
	Does anyone know how to do this?  SDL_WM_GrabInput() is designed
	to prevent the user from switching input and mouse focus away from
	the SDL application.

	Continuous relative mouse motion is not implemented.

	Wide UNICODE character input (Kanji, etc.) has not been tested.
	Latin-1 keyboard input works fine.

MacOS:
	Palette handling isn't implemented in windowed mode yet.

	Audio hasn't been extensively tested, in particular the locking
	isn't implemented and mixer routines may not call malloc() or free()
	because they are called at interrupt time.

	SDL_WM_GrabInput() is not implemented.
	Does anyone know how to do this?  SDL_WM_GrabInput() is designed
	to prevent the user from switching input and mouse focus away from
	the SDL application.

	Continuous relative mouse motion is not implemented.

	SDL_AddTimer() and SDL_RemoveTimer() haven't been implemented yet.

	Not all of the keys are properly recognized on the keyboard.

MacOS X:
	Depth switching for windowed mode isn't implemented yet.
	
	Palette handling isn't implemented in windowed mode yet.
	
	Command-line arguments dialog is not implemented yet.

	Fullscreen drawing has some artifacts.
	
	Fullscreen OpenGL for the software renderer is broken.

	Some OpenGL parameters are not accounted for, for example color bits customization.
	
	Continuous mouse motion perhaps is not as smooth as it should be.

	SDL_WM_GrabInput() is implemented, but it "freezes" the hardware
	cursor in the center of the window/screen.  Also, mouse moved events
	are not generated, and the keyboard cannot be grabbed.

	MacOS X seems to have a broken pthread_cancel() implementation.
	Actually, it just only has one cancellation point defined.
	http://lists.apple.com/archives/darwin-development/2004/Jun/24/killingapthread.001.txt

FreeBSD:
	pthread_cancel() isn't supported by FreeBSD 3.X, so threads don't
	work on versions of FreeBSD earlier than 4.0.

	The CD-ROM handling doesn't work completely.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed but needs testing)
	
	The keyboard modifiers are not set to the correct state on startup.

Solaris:
	The joystick functions are not implemented yet.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed but needs testing)
	
	The keyboard modifiers are not set to the correct state on startup.

IRIX:
	The CD-ROM handling doesn't work completely.

	The joystick functions are not implemented yet.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed but needs testing)
	
	The keyboard modifiers are not set to the correct state on startup.

EPOC:
    Only Crystal version of Epoc/SymbianOS is currently supported.

    SDL is implemented in static library only. SDL uses static/global
    variables and that is not allowed in EPOC dll libraries.

    Sound is not yet supported.

    Joystick, OpenGL and cdrom is not supported (think about cdrom in a cell phone:-).
    
    No console output screen. Printing to stdout do not have any effect.

QNX:
	Fullscreen switch doesn't work (disabled for now).
 

OpenBSD:  -= NOT YET SUPPORTED =-
	This is reported to work, but I haven't verified this.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed but needs testing)
	
	The keyboard modifiers are not set to the correct state on startup.

OSF/Tru64:  -= NOT YET SUPPORTED =-
	The audio functions are not implemented yet.

	Joysticks and CD-ROM functions are not implemented yet.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed but needs testing)
	
	The keyboard modifiers are not set to the correct state on startup.

AIX:  -= NOT YET SUPPORTED =-
	This port has only been tested with AIX 4.3.3

	The OpenGL support doesn't work yet.

	The joystick subsystem isn't implemented yet.

	Endian detection doesn't work yet - needs a unique CPP symbol.

	Wide UNICODE character input (Kanji, etc.) is not yet supported.
	It requires handling of keyboard mapping events and using the XIM
	input translation extension.  I will implement it as requested.
	Latin-1 keyboard input works fine.
	(UPDATE 04/06/2004: this bug is now fixed but needs testing)
	
	The keyboard modifiers are not set to the correct state on startup.

	The AIX port was done by Carsten.Griwodz@KOM.tu-darmstadt.de
	More information on this port is available at:
	http://www.kom.e-technik.tu-darmstadt.de/~griff/SDL/

AmigaOS:  -= NOT YET SUPPORTED =-
	The OpenGL support isn't implemented yet.

	SDL_WM_GrabInput() is not implemented.
	Does anyone know how to do this?  SDL_WM_GrabInput() is designed
	to prevent the user from switching input and mouse focus away from
	the SDL application.

	Continuous relative mouse motion is not implemented.

	The AmigaOS port was done by Gabriele.Greco@galactica.it