Fixed bug #896 John Popplewell 2009-12-08 23:05:50 PST Originally reported by AKFoerster on the mailing list. Error decoding UTF8 Russian text to UTF-16LE on Windows, but specifically on platforms without iconv support (the default on Windows). Valid UTF8 characters are flagged as being overlong and then substituted by the UNKNOWN_UNICODE character. After studying the testiconv.c example program, reading the RFCs and putting some printf statements in SDL_iconv.c the problem is in a test for 'Maximum overlong sequences', specifically 4.2.1, which is carried out by the following code: } else if ( p[0] >= 0xC0 ) { if ( (p[0] & 0xE0) != 0xC0 ) { /* Skip illegal sequences return SDL_ICONV_EILSEQ; */ ch = UNKNOWN_UNICODE; } else { if ( (p[0] & 0xCE) == 0xC0 ) { <<<<<<<< here overlong = SDL_TRUE; } ch = (Uint32)(p[0] & 0x1F); left = 1; } } else { Here is the 2-byte encoding of a character in range 00000080 - 000007FF 110xxxxx 10xxxxxx The line in question is supposed to be checking for an overlong sequence which would be less than 11000001 10111111 which should be represented as a single byte. BUT, the mask value (0xCE) is wrong, it isn't checking the top-most bit: 11000001 value 11001110 mask (incorrect) ^ and should be (0xDE): 11000001 value 11011110 mask (correct) making the above code: } else if ( p[0] >= 0xC0 ) { if ( (p[0] & 0xE0) != 0xC0 ) { /* Skip illegal sequences return SDL_ICONV_EILSEQ; */ ch = UNKNOWN_UNICODE; } else { if ( (p[0] & 0xDE) == 0xC0 ) { <<<<<<<< here overlong = SDL_TRUE; } ch = (Uint32)(p[0] & 0x1F); left = 1; } } else { I can supply a test program and/or a patch if required, best regards, John Popplewell

 ========================
  Using SDL with PicoGUI
 ========================

- Originally contributed by Micah Dowty <micahjd@users.sourceforge.net>

PicoGUI is a scalable GUI system with a unique architecture, primarily focused
on scalability to various embedded systems. You can find more information
including a FAQ at http://picogui.org

To use the patch:

  1. When compiling, add the "--enable-video-picogui" switch to ./configure

  2. When running your program, ensure that the picogui driver for SDL
     is in use by setting the SDL_VIDEODRIVER environment variable 
     to "picogui".

  3. The program must also be linked to the C client library for PicoGUI
     (libpgui.so). If the program is being compiled with a patched SDL 
     installed this should be done automatically. If you want to use an
     existing binary with PicoGUI, you can set the LD_PRELOAD environment
     variable to the path of your libpgui.so file.

Capabilities:

  So far only basic functionality is provided on true color (linear16/24/32)
  devices. Accessing a memory mapped bitmap, updating the display, and handling
  mouse/keyboard input. This functionality has been tested with several
  applications, including mplayer, Xine, sldroids, and Abuse.

TODO list:

  - YUV overlays will be helpful for watching video on set top boxes or other
    embedded devices that have some graphics acceleration hardware

  - Account for rotated bitmap storage in pgserver

  - Support for hiding or changing the cursor

  - The display should be centered when the SDL application is smaller
    than the PicoGUI panel

  - Fullscreen or any other special modes

  - Support for indexed and grayscale modes

  - Probably much more...

--- The End ---