Mercurial > sdl-ios-xcode
view test/testplatform.c @ 4324:1496aa09e41e SDL-1.2
Steven Noonan to sdl
While trying to build the SDLMain.m included with SDL 1.2.14, with
#define SDL_USE_NIB_FILE 1:
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function '-[SDLMain fixMenu:withAppName:]':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122:
warning: 'sizeToFit' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function 'main':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
warning: 'poseAsClass:' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
error: 'poseAsClass:' is unavailable (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377:
warning: passing argument 2 of 'NSApplicationMain' from incompatible
pointer type
Eric Wing to Sam
I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method.
This was deprecated in Obj-C 2.0 and not retained in 64-bit.
I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that.
Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason).
Three thoughts come to mind.
1) The Info.plist has properties to control things related to the startup class and nib.
NSPrincipalClass, NSMainNibFile
Maybe principle class needs to be SDLApplication and we can delete the poseAs
2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics.
3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance):
@interface SDLApplication : NSApplication
@end
@implementation SDLApplication
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
So instead, we change this to: (warning written in mail and untested)
@interface NSApplication (SDLApplication)
- (void) terminate:(id)sender;
@end
@implementation NSApplication (SDLApplication)
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line).
Perhaps you could ask the bug reporter to try this solution (#3).
And if that fails, maybe try #1.
-Eric
Steven Noonan to Sam
The suggested change (diff below) seems to work fine.
- Steven
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Oct 2009 21:07:12 +0000 |
parents | d83830711a5b |
children |
line wrap: on
line source
#include <stdio.h> #include "SDL.h" #include "SDL_endian.h" #include "SDL_cpuinfo.h" /* * Watcom C flags these as Warning 201: "Unreachable code" if you just * compare them directly, so we push it through a function to keep the * compiler quiet. --ryan. */ static int badsize(size_t sizeoftype, size_t hardcodetype) { return sizeoftype != hardcodetype; } int TestTypes(SDL_bool verbose) { int error = 0; if ( badsize(sizeof(Uint8), 1) ) { if ( verbose ) printf("sizeof(Uint8) != 1, instead = %ul\n", sizeof(Uint8)); ++error; } if ( badsize(sizeof(Uint16), 2) ) { if ( verbose ) printf("sizeof(Uint16) != 2, instead = %ul\n", sizeof(Uint16)); ++error; } if ( badsize(sizeof(Uint32), 4) ) { if ( verbose ) printf("sizeof(Uint32) != 4, instead = %ul\n", sizeof(Uint32)); ++error; } #ifdef SDL_HAS_64BIT_TYPE if ( badsize(sizeof(Uint64), 8) ) { if ( verbose ) printf("sizeof(Uint64) != 8, instead = %ul\n", sizeof(Uint64)); ++error; } #else if ( verbose ) { printf("WARNING: No 64-bit datatype on this platform\n"); } #endif if ( verbose && !error ) printf("All data types are the expected size.\n"); return( error ? 1 : 0 ); } int TestEndian(SDL_bool verbose) { int error = 0; Uint16 value = 0x1234; int real_byteorder; Uint16 value16 = 0xCDAB; Uint16 swapped16 = 0xABCD; Uint32 value32 = 0xEFBEADDE; Uint32 swapped32 = 0xDEADBEEF; #ifdef SDL_HAS_64BIT_TYPE Uint64 value64, swapped64; value64 = 0xEFBEADDE; value64 <<= 32; value64 |= 0xCDAB3412; swapped64 = 0x1234ABCD; swapped64 <<= 32; swapped64 |= 0xDEADBEEF; #endif if ( verbose ) { printf("Detected a %s endian machine.\n", (SDL_BYTEORDER == SDL_LIL_ENDIAN) ? "little" : "big"); } if ( (*((char *)&value) >> 4) == 0x1 ) { real_byteorder = SDL_BIG_ENDIAN; } else { real_byteorder = SDL_LIL_ENDIAN; } if ( real_byteorder != SDL_BYTEORDER ) { if ( verbose ) { printf("Actually a %s endian machine!\n", (real_byteorder == SDL_LIL_ENDIAN) ? "little" : "big"); } ++error; } if ( verbose ) { printf("Value 16 = 0x%X, swapped = 0x%X\n", value16, SDL_Swap16(value16)); } if ( SDL_Swap16(value16) != swapped16 ) { if ( verbose ) { printf("16 bit value swapped incorrectly!\n"); } ++error; } if ( verbose ) { printf("Value 32 = 0x%X, swapped = 0x%X\n", value32, SDL_Swap32(value32)); } if ( SDL_Swap32(value32) != swapped32 ) { if ( verbose ) { printf("32 bit value swapped incorrectly!\n"); } ++error; } #ifdef SDL_HAS_64BIT_TYPE if ( verbose ) { #ifdef _MSC_VER printf("Value 64 = 0x%I64X, swapped = 0x%I64X\n", value64, SDL_Swap64(value64)); #else printf("Value 64 = 0x%llX, swapped = 0x%llX\n", value64, SDL_Swap64(value64)); #endif } if ( SDL_Swap64(value64) != swapped64 ) { if ( verbose ) { printf("64 bit value swapped incorrectly!\n"); } ++error; } #endif return( error ? 1 : 0 ); } int TestCPUInfo(SDL_bool verbose) { if ( verbose ) { printf("RDTSC %s\n", SDL_HasRDTSC() ? "detected" : "not detected"); printf("MMX %s\n", SDL_HasMMX() ? "detected" : "not detected"); printf("MMX Ext %s\n", SDL_HasMMXExt() ? "detected" : "not detected"); printf("3DNow %s\n", SDL_Has3DNow() ? "detected" : "not detected"); printf("3DNow Ext %s\n", SDL_Has3DNowExt() ? "detected" : "not detected"); printf("SSE %s\n", SDL_HasSSE() ? "detected" : "not detected"); printf("SSE2 %s\n", SDL_HasSSE2() ? "detected" : "not detected"); printf("AltiVec %s\n", SDL_HasAltiVec() ? "detected" : "not detected"); } return(0); } int main(int argc, char *argv[]) { SDL_bool verbose = SDL_TRUE; int status = 0; if ( argv[1] && (SDL_strcmp(argv[1], "-q") == 0) ) { verbose = SDL_FALSE; } if ( verbose ) { printf("This system is running %s\n", #if __AIX__ "AIX" #elif __HAIKU__ /* Haiku must appear here before BeOS, since it also defines __BEOS__ */ "Haiku" #elif __BEOS__ "BeOS" #elif __BSDI__ "BSDI" #elif __DREAMCAST__ "Dreamcast" #elif __FREEBSD__ "FreeBSD" #elif __HPUX__ "HP-UX" #elif __IRIX__ "Irix" #elif __LINUX__ "Linux" #elif __MINT__ "Atari MiNT" #elif __MACOS__ "MacOS Classic" #elif __MACOSX__ "Mac OS X" #elif __NETBSD__ "NetBSD" #elif __OPENBSD__ "OpenBSD" #elif __OS2__ "OS/2" #elif __OSF__ "OSF/1" #elif __QNXNTO__ "QNX Neutrino" #elif __RISCOS__ "RISC OS" #elif __SOLARIS__ "Solaris" #elif __WIN32__ #ifdef _WIN32_WCE "Windows CE" #else "Windows" #endif #else "an unknown operating system! (see SDL_platform.h)" #endif ); } status += TestTypes(verbose); status += TestEndian(verbose); status += TestCPUInfo(verbose); return status; }