Mercurial > sdl-ios-xcode
view src/hermes/HeadMMX.h @ 4324:1496aa09e41e SDL-1.2
Steven Noonan to sdl
While trying to build the SDLMain.m included with SDL 1.2.14, with
#define SDL_USE_NIB_FILE 1:
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function '-[SDLMain fixMenu:withAppName:]':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122:
warning: 'sizeToFit' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function 'main':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
warning: 'poseAsClass:' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
error: 'poseAsClass:' is unavailable (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377:
warning: passing argument 2 of 'NSApplicationMain' from incompatible
pointer type
Eric Wing to Sam
I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method.
This was deprecated in Obj-C 2.0 and not retained in 64-bit.
I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that.
Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason).
Three thoughts come to mind.
1) The Info.plist has properties to control things related to the startup class and nib.
NSPrincipalClass, NSMainNibFile
Maybe principle class needs to be SDLApplication and we can delete the poseAs
2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics.
3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance):
@interface SDLApplication : NSApplication
@end
@implementation SDLApplication
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
So instead, we change this to: (warning written in mail and untested)
@interface NSApplication (SDLApplication)
- (void) terminate:(id)sender;
@end
@implementation NSApplication (SDLApplication)
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line).
Perhaps you could ask the bug reporter to try this solution (#3).
And if that fails, maybe try #1.
-Eric
Steven Noonan to Sam
The suggested change (diff below) seems to work fine.
- Steven
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Oct 2009 21:07:12 +0000 |
parents | 39b9405d3cb6 |
children |
line wrap: on
line source
/* Header definitions for the MMX routines for the HERMES library Copyright (c) 1998 Christian Nentwich (c.nentwich@cs.ucl.ac.uk) This source code is licensed under the GNU LGPL Please refer to the file COPYING.LIB contained in the distribution for licensing conditions */ #include "SDL_config.h" #ifndef __HERMES_HEAD_MMX__ #define __HERMES_HEAD_MMX__ /* If you cannot stand ifdefs, then please do not look into this file, it's going to end your life :) */ #ifdef X86_ASSEMBLER #ifdef __cplusplus extern "C" { #endif void STACKCALL ConvertMMX(HermesConverterInterface *); void STACKCALL ClearMMX_32(HermesClearInterface *); void STACKCALL ClearMMX_24(HermesClearInterface *); void STACKCALL ClearMMX_16(HermesClearInterface *); void STACKCALL ClearMMX_8(HermesClearInterface *); void ConvertMMXpII32_24RGB888(); void ConvertMMXpII32_16RGB565(); void ConvertMMXpII32_16BGR565(); void ConvertMMXpII32_16RGB555(); void ConvertMMXpII32_16BGR565(); void ConvertMMXpII32_16BGR555(); void ConvertMMXp32_16RGB555(); #ifdef __cplusplus } #endif /* Fix the underscore business with ELF compilers */ #if (defined(__ELF__) && defined(__GNUC__)) || defined(__SUNPRO_C) #ifdef __cplusplus extern "C" { #endif extern void _ConvertMMX(HermesConverterInterface *); extern void _ConvertMMXpII32_24RGB888(); extern void _ConvertMMXpII32_16RGB565(); extern void _ConvertMMXpII32_16BGR565(); extern void _ConvertMMXpII32_16RGB555(); extern void _ConvertMMXpII32_16BGR555(); #define ConvertMMX _ConvertMMX #define ConvertMMXpII32_24RGB888 _ConvertMMXpII32_24RGB888 #define ConvertMMXpII32_16RGB565 _ConvertMMXpII32_16RGB565 #define ConvertMMXpII32_16BGR565 _ConvertMMXpII32_16BGR565 #define ConvertMMXpII32_16RGB555 _ConvertMMXpII32_16RGB555 #define ConvertMMXpII32_16BGR555 _ConvertMMXpII32_16BGR555 #ifdef __cplusplus } #endif #endif /* ELF and GNUC */ /* Make it work with Watcom */ #ifdef __WATCOMC__ #pragma warning 601 9 #pragma aux ConvertMMX "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_32 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_24 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_16 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_8 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ConvertMMXpII32_24RGB888 "_*" #pragma aux ConvertMMXpII32_16RGB565 "_*" #pragma aux ConvertMMXpII32_16BGR565 "_*" #pragma aux ConvertMMXpII32_16RGB555 "_*" #pragma aux ConvertMMXpII32_16BGR555 "_*" #pragma aux ConvertMMXp32_16RGB555 "_*" #endif /* WATCOM */ #endif /* X86_ASSEMBLER */ #endif