Mercurial > sdl-ios-xcode
view src/video/xbios/SDL_xbios_blowup.c @ 3899:081aecdb0911 SDL-1.2
From: Gabriel Gambetta
To: SDL Mailing List <sdl@libsdl.org>
Date: Fri, 17 Nov 2006 00:39:29 -0200
Subject: [SDL] Alpha blending bug - fixed?
It turns out mm5 never got the correct value. This failed :
[...]
"movd %1, %%mm5\n\t"
: : "m" (amask), "m" (sf->Ashift) );
mm5 got 0xFF000018 instead of 0x00000018. However I did this :
Uint32 ashift = sf->Ashift;
[...]
"movd %1, %%mm5\n\t"
: : "m" (amask), "m" (ashift) );
and everything worked fine.
The only thing I could find out was that ashift is 32-bit aligned but
sf->Ashift isn't:
printf("ashift %8X [%d]\n", &ashift, (int)(&ashift) % 4);
printf("sf->Ashift %8X [%d]\n", &sf->Ashift, (int)(&sf->Ashift) % 4);
ashift at BFF0E0C4 [0]
sf->Ashift at 08AFB9CD [1]
Could this be the problem? If it is, the fix is extremely trivial.
Should I submit a patch?
--Gabriel
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Tue, 21 Nov 2006 23:17:00 +0000 |
parents | d910939febfa |
children | 782fd950bd46 c121d94672cb a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* Blowup extension definitions Patrice Mandin */ #include <mint/falcon.h> #include "SDL_xbios.h" #include "SDL_xbios_blowup.h" void SDL_XBIOS_BlowupInit(_THIS, blow_cookie_t *cookie_blow) { int i, num_mode, bank; blow_mode_t *blow_mode; /* Add bit 15 for old modes */ for (i=0;i<XBIOS_nummodes;i++) { XBIOS_modelist[i].number |= 1<<15; } /* Add Blowup modes for 8 and 16 bpp */ for (num_mode=3; num_mode<5; num_mode++) { bank = cookie_blow->num_mode[num_mode]; blow_mode = &(cookie_blow->blowup_modes[num_mode+(bank*5)]); /* Check extended mode enabled */ if (blow_mode->enabled == 0) { /* Check monitor needed for this mode */ if ((blow_mode->monitor == cookie_blow->montype) || ((blow_mode->monitor == MONITOR_TV) && (cookie_blow->montype == MONITOR_RGB)) || ((blow_mode->monitor == MONITOR_RGB) && (cookie_blow->montype == MONITOR_TV))) { /* we can use this extended mode */ SDL_XBIOS_AddMode(this, num_mode == 3 ? BPS8 : BPS16, blow_mode->width + 1, blow_mode->height + 1, num_mode == 3 ? 8 : 16, SDL_FALSE ); } } } }