Mercurial > sdl-ios-xcode
view src/video/x11/SDL_x11dga.c @ 3899:081aecdb0911 SDL-1.2
From: Gabriel Gambetta
To: SDL Mailing List <sdl@libsdl.org>
Date: Fri, 17 Nov 2006 00:39:29 -0200
Subject: [SDL] Alpha blending bug - fixed?
It turns out mm5 never got the correct value. This failed :
[...]
"movd %1, %%mm5\n\t"
: : "m" (amask), "m" (sf->Ashift) );
mm5 got 0xFF000018 instead of 0x00000018. However I did this :
Uint32 ashift = sf->Ashift;
[...]
"movd %1, %%mm5\n\t"
: : "m" (amask), "m" (ashift) );
and everything worked fine.
The only thing I could find out was that ashift is 32-bit aligned but
sf->Ashift isn't:
printf("ashift %8X [%d]\n", &ashift, (int)(&ashift) % 4);
printf("sf->Ashift %8X [%d]\n", &sf->Ashift, (int)(&sf->Ashift) % 4);
ashift at BFF0E0C4 [0]
sf->Ashift at 08AFB9CD [1]
Could this be the problem? If it is, the fix is extremely trivial.
Should I submit a patch?
--Gabriel
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Tue, 21 Nov 2006 23:17:00 +0000 |
parents | d910939febfa |
children | 782fd950bd46 c121d94672cb cbad710a6509 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* This is currently only used to enable DGA mouse. The new fullscreen code makes it very difficult to handle DGA dynamically. There will be a completely separate DGA driver that is fullscreen-only. */ #include "SDL_video.h" #include "../SDL_cursor_c.h" #include "SDL_x11dga_c.h" /* Global for the error handler */ int dga_event, dga_error = -1; void X11_EnableDGAMouse(_THIS) { #if SDL_VIDEO_DRIVER_X11_DGAMOUSE int dga_major, dga_minor; int use_dgamouse; const char *env_use_dgamouse; /* Check configuration to see if we should use DGA mouse */ use_dgamouse = 1; env_use_dgamouse = SDL_getenv("SDL_VIDEO_X11_DGAMOUSE"); if ( env_use_dgamouse ) { use_dgamouse = atoi(env_use_dgamouse); } /* Check for buggy X servers */ if ( use_dgamouse && BUGGY_XFREE86(==, 4000) ) { use_dgamouse = 0; } /* Only use DGA mouse if the cursor is not showing (in relative mode) */ if ( use_dgamouse && local_X11 && !(using_dga & DGA_MOUSE) && SDL_NAME(XF86DGAQueryExtension)(SDL_Display, &dga_event, &dga_error) && SDL_NAME(XF86DGAQueryVersion)(SDL_Display, &dga_major, &dga_minor) ) { if ( SDL_NAME(XF86DGADirectVideo)(SDL_Display, SDL_Screen, XF86DGADirectMouse) ) { using_dga |= DGA_MOUSE; } } #endif /* SDL_VIDEO_DRIVER_X11_DGAMOUSE */ } /* Argh. Glide resets DGA mouse mode when it makes the context current! */ void X11_CheckDGAMouse(_THIS) { #if SDL_VIDEO_DRIVER_X11_DGAMOUSE int flags; if ( using_dga & DGA_MOUSE ) { SDL_NAME(XF86DGAQueryDirectVideo)(SDL_Display, SDL_Screen, &flags); if ( ! (flags & XF86DGADirectMouse) ) { SDL_NAME(XF86DGADirectVideo)(SDL_Display,SDL_Screen,XF86DGADirectMouse); } } #endif } void X11_DisableDGAMouse(_THIS) { #if SDL_VIDEO_DRIVER_X11_DGAMOUSE if ( using_dga & DGA_MOUSE ) { SDL_NAME(XF86DGADirectVideo)(SDL_Display, SDL_Screen, 0); using_dga &= ~DGA_MOUSE; } #endif /* SDL_VIDEO_DRIVER_X11_DGAMOUSE */ }