Mercurial > sdl-ios-xcode
view src/hermes/HeadMMX.h @ 3899:081aecdb0911 SDL-1.2
From: Gabriel Gambetta
To: SDL Mailing List <sdl@libsdl.org>
Date: Fri, 17 Nov 2006 00:39:29 -0200
Subject: [SDL] Alpha blending bug - fixed?
It turns out mm5 never got the correct value. This failed :
[...]
"movd %1, %%mm5\n\t"
: : "m" (amask), "m" (sf->Ashift) );
mm5 got 0xFF000018 instead of 0x00000018. However I did this :
Uint32 ashift = sf->Ashift;
[...]
"movd %1, %%mm5\n\t"
: : "m" (amask), "m" (ashift) );
and everything worked fine.
The only thing I could find out was that ashift is 32-bit aligned but
sf->Ashift isn't:
printf("ashift %8X [%d]\n", &ashift, (int)(&ashift) % 4);
printf("sf->Ashift %8X [%d]\n", &sf->Ashift, (int)(&sf->Ashift) % 4);
ashift at BFF0E0C4 [0]
sf->Ashift at 08AFB9CD [1]
Could this be the problem? If it is, the fix is extremely trivial.
Should I submit a patch?
--Gabriel
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Tue, 21 Nov 2006 23:17:00 +0000 |
parents | d910939febfa |
children | 782fd950bd46 c121d94672cb 39b9405d3cb6 |
line wrap: on
line source
/* Header definitions for the MMX routines for the HERMES library Copyright (c) 1998 Christian Nentwich (c.nentwich@cs.ucl.ac.uk) This source code is licensed under the GNU LGPL Please refer to the file COPYING.LIB contained in the distribution for licensing conditions */ #include "SDL_config.h" #ifndef __HERMES_HEAD_MMX__ #define __HERMES_HEAD_MMX__ /* If you cannot stand ifdefs, then please do not look into this file, it's going to end your life :) */ #ifdef X86_ASSEMBLER #ifdef __cplusplus extern "C" { #endif void STACKCALL ConvertMMX(HermesConverterInterface *); void STACKCALL ClearMMX_32(HermesClearInterface *); void STACKCALL ClearMMX_24(HermesClearInterface *); void STACKCALL ClearMMX_16(HermesClearInterface *); void STACKCALL ClearMMX_8(HermesClearInterface *); void ConvertMMXpII32_24RGB888(); void ConvertMMXpII32_16RGB565(); void ConvertMMXpII32_16BGR565(); void ConvertMMXpII32_16RGB555(); void ConvertMMXpII32_16BGR565(); void ConvertMMXpII32_16BGR555(); void ConvertMMXp32_16RGB555(); #ifdef __cplusplus } #endif /* Fix the underscore business with ELF compilers */ #if defined(__ELF__) && defined(__GNUC__) #ifdef __cplusplus extern "C" { #endif extern void _ConvertMMX(HermesConverterInterface *); extern void _ConvertMMXpII32_24RGB888(); extern void _ConvertMMXpII32_16RGB565(); extern void _ConvertMMXpII32_16BGR565(); extern void _ConvertMMXpII32_16RGB555(); extern void _ConvertMMXpII32_16BGR555(); #define ConvertMMX _ConvertMMX #define ConvertMMXpII32_24RGB888 _ConvertMMXpII32_24RGB888 #define ConvertMMXpII32_16RGB565 _ConvertMMXpII32_16RGB565 #define ConvertMMXpII32_16BGR565 _ConvertMMXpII32_16BGR565 #define ConvertMMXpII32_16RGB555 _ConvertMMXpII32_16RGB555 #define ConvertMMXpII32_16BGR555 _ConvertMMXpII32_16BGR555 #ifdef __cplusplus } #endif #endif /* ELF and GNUC */ /* Make it work with Watcom */ #ifdef __WATCOMC__ #pragma warning 601 9 #pragma aux ConvertMMX "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_32 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_24 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_16 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_8 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ConvertMMXpII32_24RGB888 "_*" #pragma aux ConvertMMXpII32_16RGB565 "_*" #pragma aux ConvertMMXpII32_16BGR565 "_*" #pragma aux ConvertMMXpII32_16RGB555 "_*" #pragma aux ConvertMMXpII32_16BGR555 "_*" #pragma aux ConvertMMXp32_16RGB555 "_*" #endif /* WATCOM */ #endif /* X86_ASSEMBLER */ #endif