Date: Wed, 31 Dec 2003 21:55:30 +0100 From: Max Horn Subject: SDL: video/quartz cleanup while doing some experimental changes in the quartz code, I was annoyed by having to recompile that one big .o file over and over again. So I decided to finally realize one TODO: properly splitting the code over multiple files :-). With two exceptions, I didn't make code changes, only rearranged files and added new headers. Since there are several new files, making a patch didn't work out so well, so I decided to just send you all the new & modified files. The one source change I made is related to showing/hiding the mouse. I renamed cursor_visible to cursor_should_be_visible and cursor_hidden to cursor_visible; I think that makes reading the code easier. Then I added two new functions: QZ_ShowMouse and QZ_HideMouse. They help manage cursor_visible (the former 'cursor_hidden'). Finally I replaced the Carbon ShowCursor/HiderCuror calls by [NSCursor hide] and [NSCursor unhide]. The API docs are not conclusive, but it might be that with those the "cursor_visible" (former 'cursor_hidden') hack may not be necessary anymore; however so far I didn't test this hypothesis, so I left that in. The other change was to remove in_foreground and use [NSApp isActive] instead: Manually keeping track of whether we are in the foreground is error prone. This should work better in some corner cases.

--- a/src/video/quartz/Makefile.am	Wed Dec 31 04:48:38 2003 +0000
+++ b/src/video/quartz/Makefile.am	Sun Jan 04 14:55:35 2004 +0000
@@ -6,12 +6,13 @@
 
 # The SDL MacOS X Quartz video driver sources
 QUARTZ_SRCS = 			\
+	CGS.h				\
+	SDL_QuartzEvents.m	\
+	SDL_QuartzGL.m		\
 	SDL_QuartzKeys.h	\
 	SDL_QuartzVideo.h	\
-	SDL_QuartzVideo.m
-
-# These files are included by SDL_QuartzVideo.m (is that right??)
-noinst_HEADERS =		\
-	SDL_QuartzEvents.m	\
+	SDL_QuartzVideo.m	\
+	SDL_QuartzWindow.h	\
+	SDL_QuartzWindow.m	\
 	SDL_QuartzWM.m		\
-	SDL_QuartzWindow.m
+	SDL_QuartzYUV.m