Mercurial > sdl-ios-xcode
diff src/events/SDL_mouse.c @ 3191:91b335df6fc8
Fixed bug #750
Since many different event structures include windowID it should be placed near
the beginning of the structure (preferably right after type) so it's position
is the same between different events.
This is to avoid code like this:
if (event.type == SDL_WINDOWEVENT)
win = event.window.windowID;
else if ((SDL_EVENTMASK(event.type) & SDL_KEYEVENTMASK) != 0)
win = event.key.windowID;
else if (event.type == SDL_TEXTINPUT)
win = event.text.windowID;
else if (event.type == SDL_MOUSEMOTION)
win = event.motion.windowID;
else if ((SDL_EVENTMASK(event.type) & (SDL_MOUBUTTONDOWNMASK |
SDL_MOUBUTTONUPMASK)) != 0)
win = event.button.windowID;
else if (event.type == SDL_MOUSEWHEEL)
win = event.wheel.windowID;
...
in favor of:
win = event.window.windowID;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 10 Jun 2009 14:00:21 +0000 |
parents | 102b7880543a |
children | 08747e24a50f |
line wrap: on
line diff
--- a/src/events/SDL_mouse.c Wed Jun 10 13:54:13 2009 +0000 +++ b/src/events/SDL_mouse.c Wed Jun 10 14:00:21 2009 +0000 @@ -369,6 +369,8 @@ event.proximity.y = y; event.proximity.cursor = mouse->current_end; event.proximity.type = type; + /* FIXME: is this right? */ + event.proximity.windowID = mouse->focus; posted = (SDL_PushEvent(&event) > 0); if (type == SDL_PROXIMITYIN) { mouse->proximity = SDL_TRUE;