Mercurial > sdl-ios-xcode

comparison src/video/wincommon/SDL_wingl.c @ 889:eac8c69b5706

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ate: Fri, 09 Apr 2004 20:07:10 +0200 From: Hibernatus Subject: [SDL] BUG: changing video mode in opengl + windows In WIN_GL_SetupWindow (SDL12/src/video/wincommon/SDL_wingl.c) you call WIN_GL_ResetWindow when SetPixelFormat fails. WIN_GL_ResetWindow cannot properly work in its current state, because there are several things to update once you've created a new window. At least DirectInput doesn't work anymore here (which is somewhat annoying for the player :). I think you can simply remove that function. Many games don't try to recover from that exception, that's why the newest ATI drivers emulate 16 bpp display in 32 bpp mode so the error never occurs (but the games may run much slower). Having SDL_SetVideoMode return NULL would be better than actually setting the video mode and losing focus, directinput and maybe directsound too. It also made my previous drivers crash (when switching from 32 bpp windowed to 16 bpp fullscreen).
author Sam Lantinga <slouken@libsdl.org>
date Sun, 16 May 2004 18:02:48 +0000
parents b8d311d90021
children 031e093ba2a5
comparison
equal deleted inserted replaced
888:07def9d03315 889:eac8c69b5706
48 48
49 /* If we were passed a window, then we can't create a new one */ 49 /* If we were passed a window, then we can't create a new one */
50 if ( SDL_windowid ) { 50 if ( SDL_windowid ) {
51 can_reset = 0; 51 can_reset = 0;
52 } 52 }
53 #if 0 /* This doesn't work with DirectX code (see CVS comments) */
53 #ifndef _WIN32_WCE /* FIXME WinCE needs the UNICODE version of CreateWindow() */ 54 #ifndef _WIN32_WCE /* FIXME WinCE needs the UNICODE version of CreateWindow() */
54 if ( can_reset ) { 55 if ( can_reset ) {
55 /* Save the existing window attributes */ 56 /* Save the existing window attributes */
56 LONG style; 57 LONG style;
57 RECT rect = { 0, 0, 0, 0 }; 58 RECT rect = { 0, 0, 0, 0 };
70 SDL_SetError("Couldn't create window"); 71 SDL_SetError("Couldn't create window");
71 status = -1; 72 status = -1;
72 } 73 }
73 } else 74 } else
74 #endif /* !_WIN32_WCE */ 75 #endif /* !_WIN32_WCE */
76 #endif
75 { 77 {
76 SDL_SetError("Unable to reset window for OpenGL context"); 78 SDL_SetError("Unable to reset window for OpenGL context");
77 status = -1; 79 status = -1;
78 } 80 }
79 return(status); 81 return(status);