comparison src/video/x11/SDL_x11keyboard.c @ 3162:dc1eb82ffdaa

Von: Thomas Zimmermann Betreff: [SDL] [PATCH] Make static variables const Datum: Tue, 19 May 2009 19:45:37 +0200 Hi, this is a set of simple changes which make some of SDL's internal static arrays constant. The purpose is to shrink the number of write-able static bytes and thus increase the number of memory pages shared between SDL applications. The patch set is against trunk@4513. Each of the attached patch files is specific to a sub-system. The set is completed by a second mail, because of the list's 40 KiB limit. The files readelf-r4513.txt and readelf-const-patch.txt where made by calling 'readelf -S libSDL.so'. They show the difference in ELF sections without and with the patch. Some numbers measured on my x86-64: Before [13] .rodata PROGBITS 00000000000eaaa0 000eaaa0 0000000000008170 0000000000000000 A 0 0 32 [19] .data.rel.ro PROGBITS 00000000003045e0 001045e0 00000000000023d0 0000000000000000 WA 0 0 32 [23] .data PROGBITS 00000000003076e0 001076e0 0000000000004988 0000000000000000 WA 0 0 32 After [13] .rodata PROGBITS 00000000000eaaa0 000eaaa0 0000000000009a50 0000000000000000 A 0 0 32 [19] .data.rel.ro PROGBITS 0000000000306040 00106040 0000000000002608 0000000000000000 WA 0 0 32 [23] .data PROGBITS 0000000000309360 00109360 0000000000002e88 0000000000000000 WA 0 0 32 The size of the write-able data section decreased considerably. Some entries became const-after-relocation, while most of its content went straight into the read-only data section. Best regards, Thomas
author Sam Lantinga <slouken@libsdl.org>
date Wed, 03 Jun 2009 04:37:27 +0000
parents 7b031c55aebc
children cc7eca3a4e13
comparison
equal deleted inserted replaced
3161:494559cc723b 3162:dc1eb82ffdaa
30 #include <X11/keysym.h> 30 #include <X11/keysym.h>
31 31
32 #include "imKStoUCS.h" 32 #include "imKStoUCS.h"
33 33
34 /* *INDENT-OFF* */ 34 /* *INDENT-OFF* */
35 static struct { 35 static const struct {
36 KeySym keysym; 36 KeySym keysym;
37 SDLKey sdlkey; 37 SDLKey sdlkey;
38 } KeySymToSDLKey[] = { 38 } KeySymToSDLKey[] = {
39 { XK_Return, SDLK_RETURN }, 39 { XK_Return, SDLK_RETURN },
40 { XK_Escape, SDLK_ESCAPE }, 40 { XK_Escape, SDLK_ESCAPE },
130 { XK_Meta_R, SDLK_RGUI }, 130 { XK_Meta_R, SDLK_RGUI },
131 { XK_Super_R, SDLK_RGUI }, 131 { XK_Super_R, SDLK_RGUI },
132 { XK_Mode_switch, SDLK_MODE }, 132 { XK_Mode_switch, SDLK_MODE },
133 }; 133 };
134 134
135 static struct 135 static const struct
136 { 136 {
137 SDL_scancode *table; 137 const SDL_scancode const *table;
138 int table_size; 138 int table_size;
139 } scancode_set[] = { 139 } scancode_set[] = {
140 { darwin_scancode_table, SDL_arraysize(darwin_scancode_table) }, 140 { darwin_scancode_table, SDL_arraysize(darwin_scancode_table) },
141 { xfree86_scancode_table, SDL_arraysize(xfree86_scancode_table) }, 141 { xfree86_scancode_table, SDL_arraysize(xfree86_scancode_table) },
142 { xfree86_scancode_table2, SDL_arraysize(xfree86_scancode_table2) }, 142 { xfree86_scancode_table2, SDL_arraysize(xfree86_scancode_table2) },