comparison src/video/SDL_blit_N.c @ 3162:dc1eb82ffdaa

Von: Thomas Zimmermann Betreff: [SDL] [PATCH] Make static variables const Datum: Tue, 19 May 2009 19:45:37 +0200 Hi, this is a set of simple changes which make some of SDL's internal static arrays constant. The purpose is to shrink the number of write-able static bytes and thus increase the number of memory pages shared between SDL applications. The patch set is against trunk@4513. Each of the attached patch files is specific to a sub-system. The set is completed by a second mail, because of the list's 40 KiB limit. The files readelf-r4513.txt and readelf-const-patch.txt where made by calling 'readelf -S libSDL.so'. They show the difference in ELF sections without and with the patch. Some numbers measured on my x86-64: Before [13] .rodata PROGBITS 00000000000eaaa0 000eaaa0 0000000000008170 0000000000000000 A 0 0 32 [19] .data.rel.ro PROGBITS 00000000003045e0 001045e0 00000000000023d0 0000000000000000 WA 0 0 32 [23] .data PROGBITS 00000000003076e0 001076e0 0000000000004988 0000000000000000 WA 0 0 32 After [13] .rodata PROGBITS 00000000000eaaa0 000eaaa0 0000000000009a50 0000000000000000 A 0 0 32 [19] .data.rel.ro PROGBITS 0000000000306040 00106040 0000000000002608 0000000000000000 WA 0 0 32 [23] .data PROGBITS 0000000000309360 00109360 0000000000002e88 0000000000000000 WA 0 0 32 The size of the write-able data section decreased considerably. Some entries became const-after-relocation, while most of its content went straight into the read-only data section. Best regards, Thomas
author Sam Lantinga <slouken@libsdl.org>
date Wed, 03 Jun 2009 04:37:27 +0000
parents e763aa6db88b
children f7b03b6838cb
comparison
equal deleted inserted replaced
3161:494559cc723b 3162:dc1eb82ffdaa
111 * We have to assume that the bits that aren't used by other 111 * We have to assume that the bits that aren't used by other
112 * colors is alpha, and it's one complete byte, since some formats 112 * colors is alpha, and it's one complete byte, since some formats
113 * leave alpha with a zero mask, but we should still swizzle the bits. 113 * leave alpha with a zero mask, but we should still swizzle the bits.
114 */ 114 */
115 /* ARGB */ 115 /* ARGB */
116 const static struct SDL_PixelFormat default_pixel_format = { 116 const static const struct SDL_PixelFormat default_pixel_format = {
117 NULL, 32, 4, 117 NULL, 32, 4,
118 0, 0, 0, 0, 118 0, 0, 0, 0,
119 16, 8, 0, 24, 119 16, 8, 0, 24,
120 0x00FF0000, 0x0000FF00, 0x000000FF, 0xFF000000 120 0x00FF0000, 0x0000FF00, 0x000000FF, 0xFF000000
121 }; 121 };
2402 0, Blit_RGB888_RGB555, NO_ALPHA}, 2402 0, Blit_RGB888_RGB555, NO_ALPHA},
2403 /* Default for 32-bit RGB source, used if no other blitter matches */ 2403 /* Default for 32-bit RGB source, used if no other blitter matches */
2404 {0, 0, 0, 0, 0, 0, 0, 0, BlitNtoN, 0} 2404 {0, 0, 0, 0, 0, 0, 0, 0, BlitNtoN, 0}
2405 }; 2405 };
2406 2406
2407 static const struct blit_table *normal_blit[] = { 2407 static const struct blit_table *const normal_blit[] = {
2408 normal_blit_1, normal_blit_2, normal_blit_3, normal_blit_4 2408 normal_blit_1, normal_blit_2, normal_blit_3, normal_blit_4
2409 }; 2409 };
2410 2410
2411 /* Mask matches table, or table entry is zero */ 2411 /* Mask matches table, or table entry is zero */
2412 #define MASKOK(x, y) (((x) == (y)) || ((y) == 0x00000000)) 2412 #define MASKOK(x, y) (((x) == (y)) || ((y) == 0x00000000))