Mercurial > sdl-ios-xcode
comparison src/audio/esd/SDL_esdaudio.c @ 3068:b21348d47cab
Fixed bug #633
Description From Michael Stone 2008-09-25 19:27:29 (-) [reply]
To determine whether a pid is occupied with the kill(pid, 0) idiom, you have to
test
#include <signal.h>
#include <errno.h>
kill(pid, 0) < 0 && errno == ESRCH
not just
#include <signal.h>
kill(pid, 0) < 0
otherwise you get incorrect results when pid is running as a different user
(causing kill(pid, 0) to return -1 + EPERM).
src/audio/alsa/SDL_alsa_audio.c is certainly affected by this bug in both
1.2.13 and 1.3-trunk. It probably occurs in other places as well.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Tue, 17 Feb 2009 05:17:51 +0000 |
| parents | 1e431c2631ee |
| children | dc1eb82ffdaa |
comparison
equal
deleted
inserted
replaced
| 3067:bcd41b269091 | 3068:b21348d47cab |
|---|---|
| 126 /* Note that this only works with thread implementations | 126 /* Note that this only works with thread implementations |
| 127 that use a different process id for each thread. | 127 that use a different process id for each thread. |
| 128 */ | 128 */ |
| 129 /* Check every 10 loops */ | 129 /* Check every 10 loops */ |
| 130 if (this->hidden->parent && (((++cnt) % 10) == 0)) { | 130 if (this->hidden->parent && (((++cnt) % 10) == 0)) { |
| 131 if (kill(this->hidden->parent, 0) < 0) { | 131 if (kill(this->hidden->parent, 0) < 0 && errno == ESRCH) { |
| 132 this->enabled = 0; | 132 this->enabled = 0; |
| 133 } | 133 } |
| 134 } | 134 } |
| 135 } | 135 } |
| 136 | 136 |