Mercurial > sdl-ios-xcode
comparison src/audio/dma/SDL_dmaaudio.c @ 3068:b21348d47cab
Fixed bug #633
Description From Michael Stone 2008-09-25 19:27:29 (-) [reply]
To determine whether a pid is occupied with the kill(pid, 0) idiom, you have to
test
#include <signal.h>
#include <errno.h>
kill(pid, 0) < 0 && errno == ESRCH
not just
#include <signal.h>
kill(pid, 0) < 0
otherwise you get incorrect results when pid is running as a different user
(causing kill(pid, 0) to return -1 + EPERM).
src/audio/alsa/SDL_alsa_audio.c is certainly affected by this bug in both
1.2.13 and 1.3-trunk. It probably occurs in other places as well.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Tue, 17 Feb 2009 05:17:51 +0000 |
| parents | 2929ed239d2a |
| children | f7b03b6838cb |
comparison
equal
deleted
inserted
replaced
| 3067:bcd41b269091 | 3068:b21348d47cab |
|---|---|
| 415 static int cnt = 0; | 415 static int cnt = 0; |
| 416 /* Note that this only works with thread implementations | 416 /* Note that this only works with thread implementations |
| 417 that use a different process id for each thread. | 417 that use a different process id for each thread. |
| 418 */ | 418 */ |
| 419 if (parent && (((++cnt) % 10) == 0)) { /* Check every 10 loops */ | 419 if (parent && (((++cnt) % 10) == 0)) { /* Check every 10 loops */ |
| 420 if (kill(parent, 0) < 0) { | 420 if (kill(parent, 0) < 0 && errno == ESRCH) { |
| 421 this->enabled = 0; | 421 this->enabled = 0; |
| 422 } | 422 } |
| 423 } | 423 } |
| 424 } | 424 } |
| 425 | 425 |