Mercurial > sdl-ios-xcode
comparison include/SDL_config_win32.h @ 1626:a80e1e0880b8
Fixed bug #176
[I'm fixing this for the public headers, but I'm not going to bother for the SDL library code (yet)]
To clarify: Normaly, GCC (or, to be precise, the preprocessor) will ignore
this, and compile the code happily. However, one can specify -Wundef to get a
warning about this.
One can probably argue whether to consider this a bug or not; but I think that
(a) from a semantic point of view, using "#if FOO" when FOO is not defined is
strange, and (b) since it is possible to trigger a warning about this, and a
trivial fix exists, it should be corrected.
I can think of two alternative patches, BTW:
1) Simply use #define HAVE_FOO 0, instead of not defining HAVE_FOO at all
2) Change
#if HAVE_FOO
to
#if HAVE_FOO+0
which always does the right thing.
But I think I still prefer the attached patch :-).
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Thu, 13 Apr 2006 13:38:40 +0000 |
parents | d951a5afaf07 |
children | e49147870aac 2280e314a978 |
comparison
equal
deleted
inserted
replaced
1625:7e89aa7843c5 | 1626:a80e1e0880b8 |
---|---|
61 #endif /* _MSC_VER */ | 61 #endif /* _MSC_VER */ |
62 #define SDL_HAS_64BIT_TYPE 1 | 62 #define SDL_HAS_64BIT_TYPE 1 |
63 | 63 |
64 /* Enabled for SDL 1.2 (binary compatibility) */ | 64 /* Enabled for SDL 1.2 (binary compatibility) */ |
65 #define HAVE_LIBC 1 | 65 #define HAVE_LIBC 1 |
66 #if HAVE_LIBC | 66 #ifdef HAVE_LIBC |
67 /* Useful headers */ | 67 /* Useful headers */ |
68 #define HAVE_STDIO_H 1 | 68 #define HAVE_STDIO_H 1 |
69 #define STDC_HEADERS 1 | 69 #define STDC_HEADERS 1 |
70 #define HAVE_STRING_H 1 | 70 #define HAVE_STRING_H 1 |
71 #define HAVE_CTYPE_H 1 | 71 #define HAVE_CTYPE_H 1 |