Mercurial > sdl-ios-xcode
comparison src/events/SDL_mouse.c @ 3191:91b335df6fc8
Fixed bug #750
Since many different event structures include windowID it should be placed near
the beginning of the structure (preferably right after type) so it's position
is the same between different events.
This is to avoid code like this:
if (event.type == SDL_WINDOWEVENT)
win = event.window.windowID;
else if ((SDL_EVENTMASK(event.type) & SDL_KEYEVENTMASK) != 0)
win = event.key.windowID;
else if (event.type == SDL_TEXTINPUT)
win = event.text.windowID;
else if (event.type == SDL_MOUSEMOTION)
win = event.motion.windowID;
else if ((SDL_EVENTMASK(event.type) & (SDL_MOUBUTTONDOWNMASK |
SDL_MOUBUTTONUPMASK)) != 0)
win = event.button.windowID;
else if (event.type == SDL_MOUSEWHEEL)
win = event.wheel.windowID;
...
in favor of:
win = event.window.windowID;
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 10 Jun 2009 14:00:21 +0000 |
parents | 102b7880543a |
children | 08747e24a50f |
comparison
equal
deleted
inserted
replaced
3190:c68d2ca5970f | 3191:91b335df6fc8 |
---|---|
367 event.proximity.which = (Uint8) index; | 367 event.proximity.which = (Uint8) index; |
368 event.proximity.x = x; | 368 event.proximity.x = x; |
369 event.proximity.y = y; | 369 event.proximity.y = y; |
370 event.proximity.cursor = mouse->current_end; | 370 event.proximity.cursor = mouse->current_end; |
371 event.proximity.type = type; | 371 event.proximity.type = type; |
372 /* FIXME: is this right? */ | |
373 event.proximity.windowID = mouse->focus; | |
372 posted = (SDL_PushEvent(&event) > 0); | 374 posted = (SDL_PushEvent(&event) > 0); |
373 if (type == SDL_PROXIMITYIN) { | 375 if (type == SDL_PROXIMITYIN) { |
374 mouse->proximity = SDL_TRUE; | 376 mouse->proximity = SDL_TRUE; |
375 } else { | 377 } else { |
376 mouse->proximity = SDL_FALSE; | 378 mouse->proximity = SDL_FALSE; |