comparison TODO @ 3880:74e828c64315 SDL-1.2

Fixed bug #292 I might be on crack here. It looks like SDL_ConvertMono() in src/audio/SDL_audiocvt.c adds the left and right channels of a stereo stream together, and clamps the new mono channel if it would overflow. Shouldn't it be dividing by 2 to average the two sample points instead of clamping? Otherwise the mono sample point's volume doubles in the conversion. This would also make the conversion faster, as it replaces two branches per sample frame with a bitwise shift. --ryan.
author Sam Lantinga <slouken@libsdl.org>
date Sun, 24 Sep 2006 15:45:37 +0000
parents f12379c41042
children 0a53c90a37f9 c121d94672cb
comparison
equal deleted inserted replaced
3879:c82c1870c77a 3880:74e828c64315