Mercurial > sdl-ios-xcode
comparison src/video/x11/SDL_x11video.c @ 4139:568c9b3c0167 SDL-1.2
* Added configure option --enable-screensaver, to allow enabling the screensaver by default.
* Use XResetScreenSaver() instead of disabling screensaver entirely.
Full discussion summary from Erik on the SDL mailing list:
Current behaviour
=================
SDL changes the user's display power management settings without
permission from the user and without telling the user.
The interface that it uses to do so is DPMSDisable/DPMSEnable, which
should only ever be used by configuration utilities like KControl, never
by normal application programs, let alone by the libraries that they
use. Using an interface that is not at all intended for what SDL tries
to achieve means that it will not work as it should. Firstly, the power
management is completely disabled during the whole lifetime of the SDL
program, not only when it should be. Secondly, it makes SDL
non-reentrant, meaning that things will break when multiple SDL programs
are clients of the same X server simultaneously. Thirdly, no cleanup
mechanism ensures that the setting is restored if the client does not do
that (for example if it crashes).
In addition to that, this interface is broken on xorg,
[http://bugs.freedesktop.org/show_bug.cgi?id=13962], so what SDL tries
to do does not work at all on that implementation of the X Window
System. (The reason that the DPMSEnable works in KControl is that it
calls DPMSSetTimeout immediately after,
[http://websvn.kde.org/tags/KDE/3.5.9/kdebase/kcontrol/energy/energy.cpp?annotate=774532#l343]).
The problems that the current behaviour causes
==============================================
1. Information leak. When the user is away, someone might see what the
user has on the display when the user counts on the screensaver
preventing this. This does not even require physical access to the
workstation, it is enough to see it from a distance.
2. Draining battery. An SDL program that runs on a laptop will quickly
drain the battery while the user is away. The system will soon shut down
and require recharging before being usable again, while it should in
fact have consumed very little energy if the user's settings would have
been obeyed.
3. Wasting energy. Even if battery issues are not considered, energy as
such is wasted.
4. Display wear. The display may be worn out.
The problems that the current behaviour tries to solve
======================================================
1. Preventing screensaver while playing movies.
Many SDL applications are media players. They have reasons to prevent
screensavers from being activated while a movie is being played. When a
user clicks on the play button it can be interpreted as saying "play
this movie, but do not turn off the display while playing it, because I
will watch it even though I do not interact with the system".
2. Preventing screensaver when some input bypasses X.
Sometimes SDL uses input from another source than the X server, so
that the X server is bypassed. This obviously breaks the screensaver
handling. SDL tries to work around that.
3. Preventing screensaver when all input bypasses X.
There is something called Direct Graphics Access mode, where a
program takes control of both the display and the input devices from the
X server. This obviously means that the X server can not handle the
screensaver alone, since screensaver handling depends on input handling.
SDL does not do what it should to help the X server to handle the
screensaver. Nor does SDL take care of screeensaver handling itself. SDL
simply disables the screensaver completely.
How the problems should be solved
=================================
The correct way for an application program to prevent the screensaver
under X is to call XResetScreenSaver. This was recently discovered and
implemented by the mplayer developers,
[http://svn.mplayerhq.hu/mplayer?view=rev&revision=25637]. SDL needs to
wrap this in an API call (SDL_ResetScreenSaver) and implement it for the
other video targets (if they do not have a corresponding call, SDL
should do what it takes on that particular target, for example sending
fake key events).
1. When a movie is played, the player should reset the screensaver when
the animation is advanced to a new frame. The same applies to anything
similar, like slideshows.
2. When the X server is handling input, it must handle all input
(keyboards, mice, gamepads, ...). This is necessary, not only to be able
to handle the screensaver, but also so that it can send the events to
the correct (the currently active) client. If there is an input device
that the X server can not handle for some reason (such as lack of Plug
and Play capability), the program that handles the device as a
workaround must simulate what would happen if the X server would have
handled the device, by calling XResetScreenSaver when input is received
from the device.
3. When the X server is not handling the input, it depends on the
program that does to call XResetScreenSaver whenever an input event
occurs. Alternatively the program must handle the screensaver countdown
internally and call XActivateScreenSaver.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 29 Feb 2008 13:55:44 +0000 |
parents | df2f562890a0 |
children | a1b03ba2fcd0 |
comparison
equal
deleted
inserted
replaced
4138:b1fd24d62e55 | 4139:568c9b3c0167 |
---|---|
554 XSetWMProtocols(SDL_Display, WMwindow, &WM_DELETE_WINDOW, 1); | 554 XSetWMProtocols(SDL_Display, WMwindow, &WM_DELETE_WINDOW, 1); |
555 } | 555 } |
556 | 556 |
557 static int X11_VideoInit(_THIS, SDL_PixelFormat *vformat) | 557 static int X11_VideoInit(_THIS, SDL_PixelFormat *vformat) |
558 { | 558 { |
559 const char *env = NULL; | 559 const char *env; |
560 char *display; | 560 char *display; |
561 int i; | 561 int i; |
562 | 562 |
563 /* Open the X11 display */ | 563 /* Open the X11 display */ |
564 display = NULL; /* Get it from DISPLAY environment variable */ | 564 display = NULL; /* Get it from DISPLAY environment variable */ |
667 } | 667 } |
668 X11_SaveVidModeGamma(this); | 668 X11_SaveVidModeGamma(this); |
669 | 669 |
670 /* Allow environment override of screensaver disable. */ | 670 /* Allow environment override of screensaver disable. */ |
671 env = SDL_getenv("SDL_VIDEO_ALLOW_SCREENSAVER"); | 671 env = SDL_getenv("SDL_VIDEO_ALLOW_SCREENSAVER"); |
672 this->hidden->allow_screensaver = ( (env && SDL_atoi(env)) ? 1 : 0 ); | 672 if ( env ) { |
673 | 673 allow_screensaver = SDL_atoi(env); |
674 /* Save DPMS and screensaver settings */ | 674 } else { |
675 X11_SaveScreenSaver(SDL_Display, &screensaver_timeout, &dpms_enabled); | 675 #ifdef SDL_VIDEO_DISABLE_SCREENSAVER |
676 X11_DisableScreenSaver(this, SDL_Display); | 676 allow_screensaver = 0; |
677 #else | |
678 allow_screensaver = 1; | |
679 #endif | |
680 } | |
677 | 681 |
678 /* See if we have been passed a window to use */ | 682 /* See if we have been passed a window to use */ |
679 SDL_windowid = SDL_getenv("SDL_WINDOWID"); | 683 SDL_windowid = SDL_getenv("SDL_WINDOWID"); |
680 | 684 |
681 /* Create the fullscreen and managed windows */ | 685 /* Create the fullscreen and managed windows */ |
1504 /* Restore gamma settings if they've changed */ | 1508 /* Restore gamma settings if they've changed */ |
1505 if ( SDL_GetAppState() & SDL_APPACTIVE ) { | 1509 if ( SDL_GetAppState() & SDL_APPACTIVE ) { |
1506 X11_SwapVidModeGamma(this); | 1510 X11_SwapVidModeGamma(this); |
1507 } | 1511 } |
1508 | 1512 |
1509 /* Restore DPMS and screensaver settings */ | |
1510 X11_RestoreScreenSaver(this, SDL_Display, screensaver_timeout, dpms_enabled); | |
1511 | |
1512 /* Free that blank cursor */ | 1513 /* Free that blank cursor */ |
1513 if ( SDL_BlankCursor != NULL ) { | 1514 if ( SDL_BlankCursor != NULL ) { |
1514 this->FreeWMCursor(this, SDL_BlankCursor); | 1515 this->FreeWMCursor(this, SDL_BlankCursor); |
1515 SDL_BlankCursor = NULL; | 1516 SDL_BlankCursor = NULL; |
1516 } | 1517 } |