comparison src/video/SDL_video.c @ 883:50f5a29c6a17

Date: Sat, 10 Apr 2004 02:25:33 -0400 From: Glenn Maynard To: sdl@libsdl.org Subject: [SDL] SDL_SetVideoMode() failing and not setting an error (patch) Running an OpenGL SDL application off 1.2.7, at SDL_InitSubSystem(SDL_INIT_VIDEO) time: Warning: Unable to initialize AAlib mouseUsing AAlib driver: Slang driver 1.0 (slang) SDL_SetVideoMode then fails; SDL_GetError() returns "". The installation problem is straightforward: X (the higher priority driver) isn't running, so SDL is falling back on aalib. However, no error is being set when aalib fails to initialize. This also happens with the svgalib driver. SDL_video.c line ~653 sets mode to NULL, since aalib didn't return an OpenGL surface. Line ~711 ("failed setting a video mode") returns NULL. The attached patch sets an error. It's a horrible, useless error message--it should really say eg. "aalib does not support OpenGL"; this should probably be done earlier in the individual drivers, too.
author Sam Lantinga <slouken@libsdl.org>
date Sun, 11 Apr 2004 19:54:40 +0000
parents dddfc37e1f65
children 4ab6d1fd028f
comparison
equal deleted inserted replaced
882:9301b429c99f 883:50f5a29c6a17
659 SDL_PrivateResize(mode->w, mode->h); 659 SDL_PrivateResize(mode->w, mode->h);
660 660
661 /* Sam - If we asked for OpenGL mode, and didn't get it, fail */ 661 /* Sam - If we asked for OpenGL mode, and didn't get it, fail */
662 if ( is_opengl && !(mode->flags & SDL_OPENGL) ) { 662 if ( is_opengl && !(mode->flags & SDL_OPENGL) ) {
663 mode = NULL; 663 mode = NULL;
664 SDL_SetError("OpenGL not available");
664 } 665 }
665 } 666 }
666 /* 667 /*
667 * rcg11292000 668 * rcg11292000
668 * If you try to set an SDL_OPENGL surface, and fail to find a 669 * If you try to set an SDL_OPENGL surface, and fail to find a