comparison src/video/SDL_video.c @ 1257:448a9a64537b

[PATCH] SDL_GetVideoMode() does not find best mode, part 2 Following commit 1.51, I come accross a problem when SDL must choose between several video modes that could suit the one asked. If I ask 320x240 with this list: 768x480 768x240 640x400 640x200 384x480 384x240 320x400 320x200 The smallest selectables modes are 384x240 and 320x400. And SDL choose the later in this list, but 384x240 is more suitable. So I added a check to compare the pixel count (surface) of modes, and select the one which has the smallest pixel count. In my example, 384x240 has 92160 pixels, and 320x400 has 128000 pixels. So now SDL will choose 384x240 for the asked 320x240 mode.
author Patrice Mandin <patmandin@gmail.com>
date Thu, 19 Jan 2006 21:28:52 +0000
parents c2ee0f7fa711
children a7bea6db3c3e
comparison
equal deleted inserted replaced
1256:3cfb04f6e726 1257:448a9a64537b
486 for ( i=0; sizes[i]; ++i ) { 486 for ( i=0; sizes[i]; ++i ) {
487 /* Mode with both dimensions bigger or equal than asked ? */ 487 /* Mode with both dimensions bigger or equal than asked ? */
488 if ((sizes[i]->w >= *w) && (sizes[i]->h >= *h)) { 488 if ((sizes[i]->w >= *w) && (sizes[i]->h >= *h)) {
489 /* Mode with any dimension smaller or equal than current best ? */ 489 /* Mode with any dimension smaller or equal than current best ? */
490 if ((sizes[i]->w <= sizes[best]->w) || (sizes[i]->h <= sizes[best]->h)) { 490 if ((sizes[i]->w <= sizes[best]->w) || (sizes[i]->h <= sizes[best]->h)) {
491 best=i; 491 /* Now choose the mode that has less pixels */
492 supported = 1; 492 if ((sizes[i]->w * sizes[i]->h) < (sizes[best]->w * sizes[best]->h)) {
493 best=i;
494 supported = 1;
495 }
493 } 496 }
494 } 497 }
495 } 498 }
496 if (supported) { 499 if (supported) {
497 *w=sizes[best]->w; 500 *w=sizes[best]->w;