Mercurial > sdl-ios-xcode

comparison src/cdrom/win32/SDL_syscdrom.c @ 1524:38a12fd1a2c1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fixed bug #46 Date: Fri, 13 Jan 2006 18:09:45 -0500 From: mhall4400 vipmail kvcc edu Subject: Possible SDL bug Greetings I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM control portion of the library. When calling the SDL_CDPlay() function to play the last track of a CD using the offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the following error from a call to SDL_Error(): mciSendCommand() error: The specified parameter is out of range for the specified command. The code returning the error is: SDL_CDPlay(g_playingDriveSDLCD, g_playingDriveSDLCD->track[trackNumberInt].offset, g_playingDriveSDLCD->track[trackNumberInt].length) Subtracting one from the length of the provided length seems to repair the problem: SDL_CDPlay(g_playingDriveSDLCD, g_playingDriveSDLCD->track[trackNumberInt].offset, (g_playingDriveSDLCD->track[trackNumberInt].length) - 1) Ive replicated this problem on Windows 98 SE (several months since last patch), fully-patched Window ME, seldom-patched Windows XP SP1, and fully-patched Windows XP SP2. While investigating the issue, I came across a line in your librarys win32 source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add 1 to the value for length to fix MCI last track length bug. This may be the source of the issue (because subtracting 1 from the length seems to resolve the issue). Microsoft may have patched the referenced bug since you wrote that line. Mike Hall
author Sam Lantinga <slouken@libsdl.org>
date Tue, 14 Mar 2006 05:34:39 +0000
parents 84de7511f79f
children 92947e3a18db
comparison
equal deleted inserted replaced
1523:21b1fbb53f4a 1524:38a12fd1a2c1
214 if ( SDL_SYS_CDioctl(cdrom->id, MCI_STATUS, flags, 214 if ( SDL_SYS_CDioctl(cdrom->id, MCI_STATUS, flags,
215 &mci_status) == 0 ) { 215 &mci_status) == 0 ) {
216 cdrom->track[i - 1].length = MSF_TO_FRAMES( 216 cdrom->track[i - 1].length = MSF_TO_FRAMES(
217 MCI_MSF_MINUTE(mci_status.dwReturn), 217 MCI_MSF_MINUTE(mci_status.dwReturn),
218 MCI_MSF_SECOND(mci_status.dwReturn), 218 MCI_MSF_SECOND(mci_status.dwReturn),
219 MCI_MSF_FRAME(mci_status.dwReturn)) + 1; /* +1 to fix */ 219 MCI_MSF_FRAME(mci_status.dwReturn));
220 /* MCI last track length bug */
221 /* compute lead-out offset */ 220 /* compute lead-out offset */
222 cdrom->track[i].offset = cdrom->track[i - 1].offset + 221 cdrom->track[i].offset = cdrom->track[i - 1].offset +
223 cdrom->track[i - 1].length; 222 cdrom->track[i - 1].length;
224 cdrom->track[i].length = 0; 223 cdrom->track[i].length = 0;
225 okay = 1; 224 okay = 1;