annotate build-scripts/updaterev.sh @ 5082:de59e0218aa2

Fixed bug #1011 Daniel Ellis 2010-06-25 15:20:31 PDT SDL based applications sometimes display the wrong application name in the Sound Preferences dialog when using pulseaudio. I can see from the code that the SDL pulse module is initiating a new pulse audio context and passing an application name using the function get_progname(). The get_progname() function returns the name of the current process. However, the process name is often not a suitable name to use. For example, the OpenShot video editor is a python application, and so "python" is displayed in the Sound Preferences window (see Bug #596504), when it should be displaying "OpenShot". PulseAudio allows applications to specify the application name, either at the time the context is created (as SDL does currently), or by special environment variables (see http://www.pulseaudio.org/wiki/ApplicationProperties). If no name is specified, then pulseaudio will determine the name based on the process. If you specify the application name when initiating the pulseaudio context, then that will override any application name specified using an environment variable. As libsdl is a library, I believe the solution is for libsdl to not specify any application name when initiating a pulseaudio context, which will enable applications to specify the application name using environment variables. In the case that the applications do not specify anything, pulseaudio will fall back to using the process name anyway. The attached patch removes the get_progname() function and passes NULL as the application name when creating the pulseaudio context, which fixes the issue.
author Sam Lantinga <slouken@libsdl.org>
date Sun, 23 Jan 2011 21:55:04 -0800
parents e99358ca7a8d
children
rev   line source
2982
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
1 #!/bin/sh
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
2 #
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
3 # Generate a header file with the current source revision
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
4
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
5 cd `dirname $0`
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
6 srcdir=..
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
7 header=$srcdir/include/SDL_revision.h
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
8
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
9 rev=`sh showrev.sh`
4936
e99358ca7a8d Don't overwrite SDL_revision.h with a bad revision if Mercurial isn't installed
Sam Lantinga <slouken@libsdl.org>
parents: 4419
diff changeset
10 if [ "$rev" != "" -a "$rev" != "hg-0:baadf00d" ]; then
4419
5e7e1f1a4056 Changed revision details to be a string (an hg changeset) instead of an int.
Ryan C. Gordon <icculus@icculus.org>
parents: 2982
diff changeset
11 echo "#define SDL_REVISION \"$rev\"" >$header.new
2982
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
12 if diff $header $header.new >/dev/null 2>&1; then
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
13 rm $header.new
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
14 else
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
15 mv $header.new $header
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
16 fi
b64c1d23039b Make the current revision number available
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
17 fi