annotate .hgtags @ 5082:de59e0218aa2

Fixed bug #1011 Daniel Ellis 2010-06-25 15:20:31 PDT SDL based applications sometimes display the wrong application name in the Sound Preferences dialog when using pulseaudio. I can see from the code that the SDL pulse module is initiating a new pulse audio context and passing an application name using the function get_progname(). The get_progname() function returns the name of the current process. However, the process name is often not a suitable name to use. For example, the OpenShot video editor is a python application, and so "python" is displayed in the Sound Preferences window (see Bug #596504), when it should be displaying "OpenShot". PulseAudio allows applications to specify the application name, either at the time the context is created (as SDL does currently), or by special environment variables (see http://www.pulseaudio.org/wiki/ApplicationProperties). If no name is specified, then pulseaudio will determine the name based on the process. If you specify the application name when initiating the pulseaudio context, then that will override any application name specified using an environment variable. As libsdl is a library, I believe the solution is for libsdl to not specify any application name when initiating a pulseaudio context, which will enable applications to specify the application name using environment variables. In the case that the applications do not specify anything, pulseaudio will fall back to using the process name anyway. The attached patch removes the get_progname() function and passes NULL as the application name when creating the pulseaudio context, which fixes the issue.
author Sam Lantinga <slouken@libsdl.org>
date Sun, 23 Jan 2011 21:55:04 -0800
parents 5cb6424a5676
children
rev   line source
4405
7828bb19af1e update tags
convert-repo
parents:
diff changeset
1 0afe0e38e02cf2048e93582f01c52fbb91d3c7bb release-1.2.7
7828bb19af1e update tags
convert-repo
parents:
diff changeset
2 230b156829ed13b31134d96f689c917981f57b84 release-1.2.5
7828bb19af1e update tags
convert-repo
parents:
diff changeset
3 27cab50ec9c746e886ce0f3fdaa0b0cdc55a594f release-1.2.11
7828bb19af1e update tags
convert-repo
parents:
diff changeset
4 2fe3fbd2bff50165b3cad33bf40d70b3bb3c9fd0 release-1.2.3
7828bb19af1e update tags
convert-repo
parents:
diff changeset
5 3c052d3bcc76c899dfd4846be76243a78e8c7180 release-1.2.4
7828bb19af1e update tags
convert-repo
parents:
diff changeset
6 3c5eed71a3320962551af3b3dfbee0c99fcf0086 release-1.2.10
7828bb19af1e update tags
convert-repo
parents:
diff changeset
7 4867f7f7dd3426d1dbbeef48b3f3b3aa19590cc4 release-1.2.12
7828bb19af1e update tags
convert-repo
parents:
diff changeset
8 6e28dae59e3baf4447c83e833a8d2ac912536f5b release-1.2.1
7828bb19af1e update tags
convert-repo
parents:
diff changeset
9 7c2589fb8d4df54c6faabd3faebd0c0e73f67879 release-1.2.13
7828bb19af1e update tags
convert-repo
parents:
diff changeset
10 86de11faf082881ad9b73a1a1d78733ca07f8db8 release-1.2.6
7828bb19af1e update tags
convert-repo
parents:
diff changeset
11 bb051fa871aa0b53ea57df56a446cec3bb85924c release-1.2.2
7828bb19af1e update tags
convert-repo
parents:
diff changeset
12 cfcb2e1c36ebe9809577adf768b0ec53e8768af9 release-1.2.8
7828bb19af1e update tags
convert-repo
parents:
diff changeset
13 e044e7c70a50a2f54d14ee20d0933e904e5853b6 release-1.2.9
7828bb19af1e update tags
convert-repo
parents:
diff changeset
14 f14cf9d71233934811774f941d0de121d5f96ccf release-1.2.14
4462
5cb6424a5676 Tagging version before everything gets ripped out.
Sam Lantinga <slouken@libsdl.org>
parents: 4405
diff changeset
15 39c22a953456f6c9e2c8993c8ff973824104102a pre-touch-removal