Mercurial > sdl-ios-xcode
annotate src/video/photon/SDL_ph_image_c.h @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 12 Aug 2003 15:17:20 +0000 |
parents | 8bedd6d61642 |
children | aaf3b8af6616 |
rev | line source |
---|---|
0 | 1 /* |
2 SDL - Simple DirectMedia Layer | |
297
f6ffac90895c
Updated copyright information for 2002
Sam Lantinga <slouken@libsdl.org>
parents:
291
diff
changeset
|
3 Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002 Sam Lantinga |
0 | 4 |
5 This library is free software; you can redistribute it and/or | |
6 modify it under the terms of the GNU Library General Public | |
7 License as published by the Free Software Foundation; either | |
8 version 2 of the License, or (at your option) any later version. | |
9 | |
10 This library is distributed in the hope that it will be useful, | |
11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
13 Library General Public License for more details. | |
14 | |
15 You should have received a copy of the GNU Library General Public | |
16 License along with this library; if not, write to the Free | |
17 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
18 | |
19 Sam Lantinga | |
252
e8157fcb3114
Updated the source with the correct e-mail address
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
20 slouken@libsdl.org |
0 | 21 */ |
22 | |
23 #ifdef SAVE_RCSID | |
24 static char rcsid = | |
25 "@(#) $Id$"; | |
26 #endif | |
27 | |
28 #include "SDL_ph_video.h" | |
29 | |
30 extern int ph_SetupImage(_THIS, SDL_Surface *screen); | |
31 extern void ph_DestroyImage(_THIS, SDL_Surface *screen); | |
571
8e3ce997621c
Date: Thu, 16 Jan 2003 13:48:31 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
32 extern int ph_SetupUpdateFunction(_THIS, SDL_Surface *screen, Uint32 flags); |
0 | 33 |
34 extern int ph_AllocHWSurface(_THIS, SDL_Surface *surface); | |
35 extern void ph_FreeHWSurface(_THIS, SDL_Surface *surface); | |
36 extern int ph_LockHWSurface(_THIS, SDL_Surface *surface); | |
37 extern void ph_UnlockHWSurface(_THIS, SDL_Surface *surface); | |
38 extern int ph_FlipHWSurface(_THIS, SDL_Surface *surface); | |
39 | |
40 extern void ph_NormalUpdate(_THIS, int numrects, SDL_Rect *rects); | |
41 extern void ph_OCUpdate(_THIS, int numrects, SDL_Rect *rects); | |
663
8bedd6d61642
Date: Sat, 2 Aug 2003 16:22:51 +0300
Sam Lantinga <slouken@libsdl.org>
parents:
571
diff
changeset
|
42 extern void ph_OCDCUpdate(_THIS, int numrects, SDL_Rect *rects); |
291
68a8a8237c09
Date: Thu, 21 Feb 2002 09:18:24 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
252
diff
changeset
|
43 extern void ph_OpenGLUpdate(_THIS, int numrects, SDL_Rect *rects); |