annotate src/video/photon/Makefile.am @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
| author |
Sam Lantinga <slouken@libsdl.org> |
| date |
Tue, 12 Aug 2003 15:17:20 +0000 |
| parents |
e4af2c852c09 |
| children |
4ab6d1fd028f |
| rev |
line source |
|
0
|
1
|
|
|
2 ## Makefile.am for SDL using the QNX Photon video driver
|
|
|
3
|
|
|
4 noinst_LTLIBRARIES = libvideo_photon.la
|
|
|
5 libvideo_photon_la_SOURCES = $(PH_SRCS)
|
|
|
6
|
|
|
7 # The SDL QNX Photon video driver sources
|
|
|
8 PH_SRCS = \
|
|
|
9 SDL_ph_events.c \
|
|
|
10 SDL_ph_events_c.h \
|
|
|
11 SDL_ph_image.c \
|
|
|
12 SDL_ph_image_c.h \
|
|
|
13 SDL_ph_modes.c \
|
|
|
14 SDL_ph_modes_c.h \
|
|
|
15 SDL_ph_mouse.c \
|
|
|
16 SDL_ph_mouse_c.h \
|
|
|
17 SDL_ph_video.c \
|
|
|
18 SDL_ph_video.h \
|
|
|
19 SDL_ph_wm.c \
|
|
190
|
20 SDL_ph_wm_c.h \
|
|
0
|
21 SDL_phyuv.c \
|
|
|
22 SDL_phyuv_c.h
|
