Mercurial > sdl-ios-xcode
annotate mkinstalldirs @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Tue, 12 Aug 2003 15:17:20 +0000 |
| parents | 74212992fb08 |
| children |
| rev | line source |
|---|---|
| 0 | 1 #! /bin/sh |
| 2 # mkinstalldirs --- make directory hierarchy | |
| 3 # Author: Noah Friedman <friedman@prep.ai.mit.edu> | |
| 4 # Created: 1993-05-16 | |
| 5 # Public domain | |
| 6 | |
| 7 # $Id$ | |
| 8 | |
| 9 errstatus=0 | |
| 10 | |
| 11 for file | |
| 12 do | |
| 13 set fnord `echo ":$file" | sed -ne 's/^:\//#/;s/^://;s/\// /g;s/^#/\//;p'` | |
| 14 shift | |
| 15 | |
| 16 pathcomp= | |
| 17 for d | |
| 18 do | |
| 19 pathcomp="$pathcomp$d" | |
| 20 case "$pathcomp" in | |
| 21 -* ) pathcomp=./$pathcomp ;; | |
| 22 esac | |
| 23 | |
| 24 if test ! -d "$pathcomp"; then | |
| 25 echo "mkdir $pathcomp" | |
| 26 | |
| 27 mkdir "$pathcomp" || lasterr=$? | |
| 28 | |
| 29 if test ! -d "$pathcomp"; then | |
| 30 errstatus=$lasterr | |
| 31 fi | |
| 32 fi | |
| 33 | |
| 34 pathcomp="$pathcomp/" | |
| 35 done | |
| 36 done | |
| 37 | |
| 38 exit $errstatus | |
| 39 | |
| 40 # mkinstalldirs ends here |