Mercurial > sdl-ios-xcode
annotate TODO @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Tue, 12 Aug 2003 15:17:20 +0000 |
| parents | df1d68818edb |
| children | 19418e4422cb |
| rev | line source |
|---|---|
| 0 | 1 |
| 2 Wish list for the 1.3 development branch: | |
| 3 | |
|
2
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
4 * Use /etc/fb.modes, if available, like GGI does |
| 0 | 5 * Add mousewheel events (new unified event architecture?) |
| 6 * DirectInput joystick support needs to be implemented | |
| 7 * Be able to enumerate and select available audio and video drivers | |
| 8 * Fullscreen video mode support for MacOS X | |
| 9 * Explicit vertical retrace wait (maybe separate from SDL_Flip?) | |
| 10 * Shaped windows, windows without borders | |
| 11 * Multiple windows, multiple display support | |
| 12 * SDL_INIT_EVENTTHREAD on Windows and MacOS? | |
| 13 * Add a timestamp to events | |
| 14 * Use RDTSC for timer resolution on x86 hardware | |
| 15 * Add audio input API | |
|
2
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
16 * Add hardware accelerated scaled blit |
|
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
17 * Add hardware accelerated alpha blits |
|
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
18 * Redesign blitting architecture to allow blit plugins |
| 0 | 19 |
| 20 In the jump from 1.2 to 1.3, we should change the SDL_Rect members to | |
| 21 int and evaluate all the rest of the datatypes. This is the only place | |
| 22 we should do it though, since the 1.2 series should not break binary | |
| 23 compatibility in this way. | |
| 150 | 24 |
| 25 Requests: | |
| 26 * PCM and CDROM volume control (deprecated, but possible) |