Mercurial > sdl-ios-xcode
annotate .cvsignore @ 1258:b2283b0ded26
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event
Hi,
Patch in question:
--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;
/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;
Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.
2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace
3) It can't harm plain C because tags are living in a different namespace
than typenames
4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.
5) Right now I have to include SDL/event.h from a C++ header file. See 2)
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 20 Jan 2006 13:07:25 +0000 (2006-01-20) |
parents | 9454950842ae |
children | d94b080ff6ce |
rev | line source |
---|---|
0 | 1 aclocal.m4 |
1015
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
2 autom4te* |
0 | 3 config.cache |
1015
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
4 config.log |
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
5 config.status |
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
6 configure |
596
475f969e8c01
CVS should ignore files automatically generated by building on MacOS X
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
7 depcomp |
1001
70bfe658442c
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
754
diff
changeset
|
8 install-sh |
0 | 9 libtool |
10 Makefile | |
1015
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
11 Makefile.in |
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
12 missing |
9454950842ae
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1001
diff
changeset
|
13 mkinstalldirs |
0 | 14 sdl-config |
15 SDL.spec | |
703
ca809c1b41ca
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
596
diff
changeset
|
16 SDL.qpg |
596
475f969e8c01
CVS should ignore files automatically generated by building on MacOS X
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
17 .DS_Store |