annotate test/autogen.sh @ 4511:ae7799d16c87

Daniel Wyatt 2010-03-26 14:52:53 PDT If a non-console Windows SDL program has a non-quoted 0th argument followed optionally by more non-quoted arguments and then by an empty quoted argument, it will crash (attempts to dereference a NULL pointer). In other words, something like this: test.exe [non-quoted args] "" [...] The fix is a one-liner in ParseCommandLine() of src/main/win32/SDL_win32_main.c. You can test this with any non-console SDL program on windows like this: 1) Open a console (cmd.exe) 2) Launch the program in one of the following ways: program "" program arg1 "" program arg1 "" arg3 These will not cause a crash: "program" [...] program "arg1" "" When a Windows program is launched from Explorer, its 0th argument seems to always be quoted, so it won't be a problem in that case. I've tested this on Windows XP SP3 and Windows 7.
author Sam Lantinga <slouken@libsdl.org>
date Mon, 12 Jul 2010 22:08:50 -0700
parents e566046c73d9
children
rev   line source
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
1 #!/bin/sh
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
2 #
1380
d94b080ff6ce Completely removed dependency on automake
Sam Lantinga <slouken@libsdl.org>
parents: 982
diff changeset
3 # Regenerate configuration files
d94b080ff6ce Completely removed dependency on automake
Sam Lantinga <slouken@libsdl.org>
parents: 982
diff changeset
4 cp acinclude.m4 aclocal.m4
1564
4950a25bd91e Show an error message if autoconf isn't found
Sam Lantinga <slouken@libsdl.org>
parents: 1563
diff changeset
5 found=false
1833
e566046c73d9 Added yet another variant of autoconf to the list
Sam Lantinga <slouken@libsdl.org>
parents: 1564
diff changeset
6 for autoconf in autoconf autoconf259 autoconf-2.59
1564
4950a25bd91e Show an error message if autoconf isn't found
Sam Lantinga <slouken@libsdl.org>
parents: 1563
diff changeset
7 do if which $autoconf >/dev/null 2>&1; then $autoconf && found=true; break; fi
1563
b054590b967a Fall back to autogen259 if autogen isn't available
Sam Lantinga <slouken@libsdl.org>
parents: 1380
diff changeset
8 done
1564
4950a25bd91e Show an error message if autoconf isn't found
Sam Lantinga <slouken@libsdl.org>
parents: 1563
diff changeset
9 if test x$found = xfalse; then
4950a25bd91e Show an error message if autoconf isn't found
Sam Lantinga <slouken@libsdl.org>
parents: 1563
diff changeset
10 echo "Couldn't find autoconf, aborting"
4950a25bd91e Show an error message if autoconf isn't found
Sam Lantinga <slouken@libsdl.org>
parents: 1563
diff changeset
11 exit 1
4950a25bd91e Show an error message if autoconf isn't found
Sam Lantinga <slouken@libsdl.org>
parents: 1563
diff changeset
12 fi