annotate src/main/win32/version.rc @ 4511:ae7799d16c87

Daniel Wyatt 2010-03-26 14:52:53 PDT If a non-console Windows SDL program has a non-quoted 0th argument followed optionally by more non-quoted arguments and then by an empty quoted argument, it will crash (attempts to dereference a NULL pointer). In other words, something like this: test.exe [non-quoted args] "" [...] The fix is a one-liner in ParseCommandLine() of src/main/win32/SDL_win32_main.c. You can test this with any non-console SDL program on windows like this: 1) Open a console (cmd.exe) 2) Launch the program in one of the following ways: program "" program arg1 "" program arg1 "" arg3 These will not cause a crash: "program" [...] program "arg1" "" When a Windows program is launched from Explorer, its 0th argument seems to always be quoted, so it won't be a problem in that case. I've tested this on Windows XP SP3 and Windows 7.
author Sam Lantinga <slouken@libsdl.org>
date Mon, 12 Jul 2010 22:08:50 -0700
parents 99210400e8b9
children
rev   line source
2212
fdadda42d4d4 Switched afxres.h to winresrc.h
Sam Lantinga <slouken@libsdl.org>
parents: 2204
diff changeset
1
fdadda42d4d4 Switched afxres.h to winresrc.h
Sam Lantinga <slouken@libsdl.org>
parents: 2204
diff changeset
2 #include "winresrc.h"
2204
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
3
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
4 LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
5
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
6 /////////////////////////////////////////////////////////////////////////////
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
7 //
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
8 // Version
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
9 //
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
10
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
11 VS_VERSION_INFO VERSIONINFO
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
12 FILEVERSION 1,3,0,0
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
13 PRODUCTVERSION 1,3,0,0
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
14 FILEFLAGSMASK 0x3fL
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
15 FILEFLAGS 0x0L
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
16 FILEOS 0x40004L
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
17 FILETYPE 0x2L
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
18 FILESUBTYPE 0x0L
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
19 BEGIN
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
20 BLOCK "StringFileInfo"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
21 BEGIN
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
22 BLOCK "040904b0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
23 BEGIN
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
24 VALUE "CompanyName", "\0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
25 VALUE "FileDescription", "SDL\0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
26 VALUE "FileVersion", "1, 3, 0, 0\0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
27 VALUE "InternalName", "SDL\0"
2859
99210400e8b9 Updated copyright date
Sam Lantinga <slouken@libsdl.org>
parents: 2212
diff changeset
28 VALUE "LegalCopyright", "Copyright © 2009 Sam Lantinga\0"
2204
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
29 VALUE "OriginalFilename", "SDL.dll\0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
30 VALUE "ProductName", "Simple DirectMedia Layer\0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
31 VALUE "ProductVersion", "1, 3, 0, 0\0"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
32 END
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
33 END
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
34 BLOCK "VarFileInfo"
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
35 BEGIN
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
36 VALUE "Translation", 0x409, 1200
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
37 END
9f64d06fa168 Added support for building version.rc in Windows build.
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
38 END