annotate src/main/dummy/SDL_dummy_main.c @ 4511:ae7799d16c87

Daniel Wyatt 2010-03-26 14:52:53 PDT If a non-console Windows SDL program has a non-quoted 0th argument followed optionally by more non-quoted arguments and then by an empty quoted argument, it will crash (attempts to dereference a NULL pointer). In other words, something like this: test.exe [non-quoted args] "" [...] The fix is a one-liner in ParseCommandLine() of src/main/win32/SDL_win32_main.c. You can test this with any non-console SDL program on windows like this: 1) Open a console (cmd.exe) 2) Launch the program in one of the following ways: program "" program arg1 "" program arg1 "" arg3 These will not cause a crash: "program" [...] program "arg1" "" When a Windows program is launched from Explorer, its 0th argument seems to always be quoted, so it won't be a problem in that case. I've tested this on Windows XP SP3 and Windows 7.
author Sam Lantinga <slouken@libsdl.org>
date Mon, 12 Jul 2010 22:08:50 -0700
parents 791b3256fb22
children
rev   line source
754
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
1
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
2 /* Include the SDL main definition header */
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
3 #include "SDL_main.h"
846
96ba4eab74fb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 754
diff changeset
4
754
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
5 #ifdef main
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
6 #undef main
1895
c121d94672cb SDL 1.2 is moving to a branch, and SDL 1.3 is becoming the head.
Sam Lantinga <slouken@libsdl.org>
parents: 1753
diff changeset
7 int
c121d94672cb SDL 1.2 is moving to a branch, and SDL 1.3 is becoming the head.
Sam Lantinga <slouken@libsdl.org>
parents: 1753
diff changeset
8 main(int argc, char *argv[])
754
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
9 {
1895
c121d94672cb SDL 1.2 is moving to a branch, and SDL 1.3 is becoming the head.
Sam Lantinga <slouken@libsdl.org>
parents: 1753
diff changeset
10 return (SDL_main(argc, argv));
754
623b453a3219 Fixed "dist" make target for newer versions of automake
Sam Lantinga <slouken@libsdl.org>
parents:
diff changeset
11 }
846
96ba4eab74fb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 754
diff changeset
12 #else
1753
5b3bb08e7dd8 SDL_dummy_main.c:12: warning: ISO C does not allow extra â;â outside of a function
Sam Lantinga <slouken@libsdl.org>
parents: 846
diff changeset
13 /* Nothing to do on this platform */
1949
44b6f09a07d8 Placate versions of ranlib which complain about empty files (Mac OS X 10.4)
Sam Lantinga <slouken@libsdl.org>
parents: 1895
diff changeset
14 int
4472
791b3256fb22 Mostly cleaned up warnings with -Wmissing-prototypes
Sam Lantinga <slouken@libsdl.org>
parents: 1949
diff changeset
15 SDL_main_stub_symbol(void);
791b3256fb22 Mostly cleaned up warnings with -Wmissing-prototypes
Sam Lantinga <slouken@libsdl.org>
parents: 1949
diff changeset
16
791b3256fb22 Mostly cleaned up warnings with -Wmissing-prototypes
Sam Lantinga <slouken@libsdl.org>
parents: 1949
diff changeset
17 int
791b3256fb22 Mostly cleaned up warnings with -Wmissing-prototypes
Sam Lantinga <slouken@libsdl.org>
parents: 1949
diff changeset
18 SDL_main_stub_symbol(void)
1949
44b6f09a07d8 Placate versions of ranlib which complain about empty files (Mac OS X 10.4)
Sam Lantinga <slouken@libsdl.org>
parents: 1895
diff changeset
19 {
44b6f09a07d8 Placate versions of ranlib which complain about empty files (Mac OS X 10.4)
Sam Lantinga <slouken@libsdl.org>
parents: 1895
diff changeset
20 return 0;
44b6f09a07d8 Placate versions of ranlib which complain about empty files (Mac OS X 10.4)
Sam Lantinga <slouken@libsdl.org>
parents: 1895
diff changeset
21 }
846
96ba4eab74fb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 754
diff changeset
22 #endif
1949
44b6f09a07d8 Placate versions of ranlib which complain about empty files (Mac OS X 10.4)
Sam Lantinga <slouken@libsdl.org>
parents: 1895
diff changeset
23
1895
c121d94672cb SDL 1.2 is moving to a branch, and SDL 1.3 is becoming the head.
Sam Lantinga <slouken@libsdl.org>
parents: 1753
diff changeset
24 /* vi: set ts=4 sw=4 expandtab: */