Mercurial > sdl-ios-xcode
annotate src/libm/s_fabs.c @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | dc1eb82ffdaa |
children |
rev | line source |
---|---|
2756
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
1 /* @(#)s_fabs.c 5.1 93/09/24 */ |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
2 /* |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
3 * ==================================================== |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
4 * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
5 * |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
6 * Developed at SunPro, a Sun Microsystems, Inc. business. |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
7 * Permission to use, copy, modify, and distribute this |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
8 * software is freely granted, provided that this notice |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
9 * is preserved. |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
10 * ==================================================== |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
11 */ |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
12 |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
13 #if defined(LIBM_SCCS) && !defined(lint) |
3162 | 14 static const char rcsid[] = |
15 "$NetBSD: s_fabs.c,v 1.7 1995/05/10 20:47:13 jtc Exp $"; | |
2756
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
16 #endif |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
17 |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
18 /* |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
19 * fabs(x) returns the absolute value of x. |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
20 */ |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
21 |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
22 #include "math.h" |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
23 #include "math_private.h" |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
24 |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
25 libm_hidden_proto(fabs) |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
26 #ifdef __STDC__ |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
27 double fabs(double x) |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
28 #else |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
29 double fabs(x) |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
30 double x; |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
31 #endif |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
32 { |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
33 u_int32_t high; |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
34 GET_HIGH_WORD(high, x); |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
35 SET_HIGH_WORD(x, high & 0x7fffffff); |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
36 return x; |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
37 } |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
38 |
a98604b691c8
Expanded the libm support and put it into a separate directory.
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
39 libm_hidden_def(fabs) |