Mercurial > sdl-ios-xcode
annotate acinclude/ac_check_define.m4 @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | 725b16784e96 |
children |
rev | line source |
---|---|
3342
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
1 define(AC_CHECK_DEFINE,[dnl |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
2 AC_CACHE_CHECK(for $1 in $2, ac_cv_define_$1, |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
3 AC_EGREP_CPP([YES_IS_DEFINED], [ |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
4 #include <$2> |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
5 #ifdef $1 |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
6 YES_IS_DEFINED |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
7 #endif |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
8 ], ac_cv_define_$1=yes, ac_cv_define_$1=no) |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
9 ) |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
10 if test "$ac_cv_define_$1" = "yes" ; then |
3374
725b16784e96
MatÄ›j TÃ½Ä 2009-10-05 14:09:03 PDT
Sam Lantinga <slouken@libsdl.org>
parents:
3342
diff
changeset
|
11 AC_DEFINE([HAVE_$1],[],[Added by AC_CHECK_DEFINE]) |
3342
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
12 fi |
3da232c5980a
Split acinclude.m4 into its constituent parts for easy upgrading
Sam Lantinga <slouken@libsdl.org>
parents:
diff
changeset
|
13 ])dnl |
3374
725b16784e96
MatÄ›j TÃ½Ä 2009-10-05 14:09:03 PDT
Sam Lantinga <slouken@libsdl.org>
parents:
3342
diff
changeset
|
14 AC_DEFINE([HAVE_$1],[],[Added by AC_CHECK_DEFINE]) |