Mercurial > sdl-ios-xcode
annotate src/hermes/mmx_main.asm @ 4167:a6f635e5eaa6 SDL-1.2
Fixed bug #611
From Tim Angus 2008-08-12 11:18:06
I'm one of the maintainers of ioquake3.org, an updated version of the
Quake 3 engine. Relatively recently, we moved ioq3 to use SDL as a
replacement for 95% of the platform specific code that was there. On the
whole it's doing a great job but unfortunately since the move we've been
getting complaints about the quality of the mouse input on the Windows
platform to the point where for many the game is unplayable. Put in
other terms, the current stable SDL 1.2 is basically not fit for purpose
if you need high quality mouse input as you do in a first person shooter.
Over the weekend I decided to pull my finger out and actually figure out
what's going on. There are basically two major problems. Firstly, when
using the "windib" driver, mouse input is gathered via the WM_MOUSEMOVE
message. Googling for this indicates that often this is known to result
in "spurious" and/or "missing" mouse movement events; this is the
primary cause of the poor mouse input. The second problem is that the
"directx" driver does not work at all in combination with OpenGL meaning
that you can't use DirectInput if your application also uses OpenGL. In
other words you're locked into using the "windib" driver and its poor
mouse input.
In order to address these problems I've done the following:
* Remove WM_MOUSEMOVE based motion event generation and replace with
calls to GetCursorPos which seems much more reliable. In order to
achieve this I've moved mouse motion out into a separate function that
is called once per DIB_PumpEvents.
* Remove the restriction on the "directx" driver being inoperable in
combination with OpenGL. There is a bug for this issues that I've
hijacked to a certain extent
(http://bugzilla.libsdl.org/show_bug.cgi?id=265). I'm the first to admit
I don't really understand why this restriction is there in the first
place. The commit message for the bug fix that introduced this
restriction (r581) isn't very elaborate and I couldn't see any other bug
tracking the issue. If anyone has more information on the bug that was
avoided by r581 it would be helpful as I/someone could then look into
addressing the problem without disabling the "directx" driver.
* I've also removed the restriction on not being allowed to use
DirectInput in windowed mode. I couldn't see any reason for this, at
least not from our perspective. I have my suspicions that it'll be
something like matching up the cursor with the mouse coordinates...
* I bumped up the DirectInput API used to version 7 in order to get
access to mouse buttons 4-7. I've had to inject a little bit of the DX7
headers into SDL there as the MinGW ones aren't up to date in this respect.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Thu, 02 Apr 2009 04:43:36 +0000 |
parents | 540466e900db |
children |
rev | line source |
---|---|
0 | 1 ; |
2 ; mmx format converter main loops for HERMES | |
3 ; Some routines Copyright (c) 1998 Christian Nentwich (c.nentwich@cs.ucl.ac.uk) | |
4 ; This source code is licensed under the GNU LGPL | |
5 ; | |
6 ; Please refer to the file COPYING.LIB contained in the distribution for | |
7 ; licensing conditions | |
8 ; | |
9 | |
10 BITS 32 | |
11 | |
1873
eb4d9d99849b
Renamed, per Mike's comment on bug #157
Sam Lantinga <slouken@libsdl.org>
parents:
1871
diff
changeset
|
12 %include "common.inc" |
1871 | 13 |
14 SDL_FUNC _ConvertMMX | |
0 | 15 |
16 SECTION .text | |
17 | |
18 ;; _ConvertMMX: | |
19 ;; [ESP+8] ConverterInfo* | |
20 ;; -------------------------------------------------------------------------- | |
21 ;; ConverterInfo (ebp+..) | |
22 ;; 0: void *s_pixels | |
23 ;; 4: int s_width | |
24 ;; 8: int s_height | |
25 ;; 12: int s_add | |
26 ;; 16: void *d_pixels | |
27 ;; 20: int d_width | |
28 ;; 24: int d_height | |
29 ;; 28: int d_add | |
30 ;; 32: void (*converter_function)() | |
31 ;; 36: int32 *lookup | |
32 | |
33 _ConvertMMX: | |
34 push ebp | |
35 mov ebp,esp | |
36 | |
37 ; Save the registers used by the blitters, necessary for optimized code | |
38 pusha | |
39 | |
40 mov eax,[ebp+8] | |
41 | |
42 cmp dword [eax+4],BYTE 0 | |
43 je endconvert | |
44 | |
45 mov ebp,eax | |
46 | |
47 mov esi,[ebp+0] | |
48 mov edi,[ebp+16] | |
49 | |
50 y_loop: | |
51 mov ecx,[ebp+4] | |
52 | |
3983
540466e900db
Removed textrels from hermes code.
Ryan C. Gordon <icculus@icculus.org>
parents:
1873
diff
changeset
|
53 call [ebp+32] |
0 | 54 |
55 add esi,[ebp+12] | |
56 add edi,[ebp+28] | |
57 | |
58 dec dword [ebp+8] | |
59 jnz y_loop | |
60 | |
61 | |
62 ; Restore the registers used by the blitters, necessary for optimized code | |
63 popa | |
64 | |
65 pop ebp | |
66 | |
67 endconvert: | |
68 emms | |
69 | |
70 ret | |
71 | |
1199
2d6dc7de1145
From: Mike Frysinger <vapier@gentoo.org>
Ryan C. Gordon <icculus@icculus.org>
parents:
1166
diff
changeset
|
72 %ifidn __OUTPUT_FORMAT__,elf |
2d6dc7de1145
From: Mike Frysinger <vapier@gentoo.org>
Ryan C. Gordon <icculus@icculus.org>
parents:
1166
diff
changeset
|
73 section .note.GNU-stack noalloc noexec nowrite progbits |
2d6dc7de1145
From: Mike Frysinger <vapier@gentoo.org>
Ryan C. Gordon <icculus@icculus.org>
parents:
1166
diff
changeset
|
74 %endif |