Mercurial > sdl-ios-xcode
annotate BUGS @ 4393:9afe12fb4c41 SDL-1.2
Fixed bug #901
Tim Angus 2009-12-11 11:45:46 PST
Disable mouse event generation when state is not SDL_APPMOUSEFOCUS
If a Windows SDL application is minimised by using alt-tab, SDL_APPMOUSEFOCUS
is lost as part of the minimisation. Unfortunately, the directx driver doesn't
pay any attention to this state when generating mouse button events, so
clicking on the Desktop can cause mouse clicks in the SDL application, while
it's still minimised. The attached patch fixes this. It looks much more
complicated than it actually is due to indentation; here it is ignoring
whitespace:
tma@abraxas:~/sources/SDL-1.2-svn$ svn diff -x -b
Index: src/video/windx5/SDL_dx5events.c
===================================================================
--- src/video/windx5/SDL_dx5events.c (revision 5376)
+++ src/video/windx5/SDL_dx5events.c (working copy)
@@ -374,10 +374,9 @@
if ( !(SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) {
mouse_lost = 1;
ClipCursor(NULL);
- }
-
+ } else {
/* If the mouse was lost, regain some sense of mouse state */
- if ( mouse_lost && (SDL_GetAppState() & SDL_APPMOUSEFOCUS) ) {
+ if ( mouse_lost ) {
POINT mouse_pos;
Uint8 old_state;
Uint8 new_state;
@@ -548,6 +547,7 @@
if ( xrel || yrel ) {
post_mouse_motion(1, xrel, yrel);
}
+ }
}
/* The main Win32 event handler */
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 14 Dec 2009 22:41:31 +0000 |
parents | 89b0f3d12fe2 |
children |
rev | line source |
---|---|
0 | 1 |
3915
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
2 Bugs are now managed in the SDL bug tracker, here: |
0 | 3 |
3915
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
4 http://bugzilla.libsdl.org/ |
0 | 5 |
3915
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
6 You may report bugs there, and search to see if a given issue has already |
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
7 been reported, discussed, and maybe even fixed. |
0 | 8 |
9 | |
27
a7e598a8d8be
The keyboard modifiers are not set to the correct state on X11 startup.
Sam Lantinga <slouken@lokigames.com>
parents:
21
diff
changeset
|
10 |
3915
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
11 You may also find help at the SDL mailing list. Subscription information: |
0 | 12 |
3915
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
13 http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org |
250
74a8f672f2f8
Added support for building SDL for EPOC/SymbianOS 6.0 (thanks Hannu!)
Sam Lantinga <slouken@libsdl.org>
parents:
172
diff
changeset
|
14 |
3915
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
15 Bug reports are welcome here, but we really appreciate if you use Bugzilla, as |
89b0f3d12fe2
Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents:
3888
diff
changeset
|
16 bugs discussed on the mailing list may be forgotten or missed. |
0 | 17 |
27
a7e598a8d8be
The keyboard modifiers are not set to the correct state on X11 startup.
Sam Lantinga <slouken@lokigames.com>
parents:
21
diff
changeset
|
18 |