Mercurial > sdl-ios-xcode
annotate src/events/SDL_resize.c @ 4168:69bcba65c388 SDL-1.2
Fixed bug #526
Comment #1 From Simon Howard 2009-03-20 16:50:56
Hi,
I'm the author of Chocolate Doom, one of the other source ports that James
mentioned. This is a patch against the current SVN version of SDL 1.2 that
fixes the bug. It has been tested and hopefully should be obviously correct
from examining the changes. I'll give a brief explanation.
When the palette is set with SDL_SetPalette, the IDirectDrawPalette_SetEntries
DirectX function is invoked. However, when this happens, a WM_PALETTECHANGED
message is sent to the window.
A WM_PALETTECHANGED message can also be received if the palette is changed for
some other reason, like if the system palette is changed. Therefore, the
palette change handler (DX5_PaletteChanged) has code to deal with this case.
It distinguishes "expected" palette changes (set with SDL_SetPalette) from
"unexpected" palette changes using the colorchange_expected variable, which is
set before calling IDirectDrawPalette_SetEntries. However, the code to set
this variable is missing in the fullscreen code path. By setting this
variable, the palette change is handled properly and the freezes go away.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Mon, 13 Apr 2009 00:53:12 +0000 |
| parents | a1b03ba2fcd0 |
| children | 429c8dd3175d |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 2 SDL - Simple DirectMedia Layer | |
| 4159 | 3 Copyright (C) 1997-2009 Sam Lantinga |
| 0 | 4 |
| 5 This library is free software; you can redistribute it and/or | |
|
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1190
diff
changeset
|
6 modify it under the terms of the GNU Lesser General Public |
| 0 | 7 License as published by the Free Software Foundation; either |
|
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1190
diff
changeset
|
8 version 2.1 of the License, or (at your option) any later version. |
| 0 | 9 |
| 10 This library is distributed in the hope that it will be useful, | |
| 11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
|
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1190
diff
changeset
|
13 Lesser General Public License for more details. |
| 0 | 14 |
|
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1190
diff
changeset
|
15 You should have received a copy of the GNU Lesser General Public |
|
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1190
diff
changeset
|
16 License along with this library; if not, write to the Free Software |
|
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1190
diff
changeset
|
17 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA |
| 0 | 18 |
| 19 Sam Lantinga | |
|
252
e8157fcb3114
Updated the source with the correct e-mail address
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
20 slouken@libsdl.org |
| 0 | 21 */ |
|
1402
d910939febfa
Use consistent identifiers for the various platforms we support.
Sam Lantinga <slouken@libsdl.org>
parents:
1361
diff
changeset
|
22 #include "SDL_config.h" |
| 0 | 23 |
| 24 /* Resize event handling code for SDL */ | |
| 25 | |
| 26 #include "SDL_events.h" | |
| 27 #include "SDL_events_c.h" | |
|
1361
19418e4422cb
New configure-based build system. Still work in progress, but much improved
Sam Lantinga <slouken@libsdl.org>
parents:
1312
diff
changeset
|
28 #include "../video/SDL_sysvideo.h" |
| 0 | 29 |
| 30 | |
| 31 /* Keep the last resize event so we don't post duplicates */ | |
| 32 static struct { | |
| 33 int w; | |
| 34 int h; | |
| 35 } last_resize; | |
| 36 | |
| 37 /* This is global for SDL_eventloop.c */ | |
| 38 int SDL_PrivateResize(int w, int h) | |
| 39 { | |
| 40 int posted; | |
| 41 SDL_Event events[32]; | |
| 42 | |
| 43 /* See if this event would change the video surface */ | |
| 1190 | 44 if ( !w || !h |
| 45 #ifndef __OS2__ | |
| 46 || ((last_resize.w == w) && (last_resize.h == h)) | |
| 47 #endif | |
| 48 ) { | |
| 0 | 49 return(0); |
| 50 } | |
| 51 last_resize.w = w; | |
| 52 last_resize.h = h; | |
| 53 if ( ! SDL_VideoSurface || | |
| 54 ((w == SDL_VideoSurface->w) && (h == SDL_VideoSurface->h)) ) { | |
| 55 return(0); | |
| 56 } | |
| 57 | |
| 58 /* Pull out all old resize events */ | |
| 59 SDL_PeepEvents(events, sizeof(events)/sizeof(events[0]), | |
| 60 SDL_GETEVENT, SDL_VIDEORESIZEMASK); | |
| 61 | |
| 62 /* Post the event, if desired */ | |
| 63 posted = 0; | |
| 64 if ( SDL_ProcessEvents[SDL_VIDEORESIZE] == SDL_ENABLE ) { | |
| 65 SDL_Event event; | |
| 66 event.type = SDL_VIDEORESIZE; | |
| 67 event.resize.w = w; | |
| 68 event.resize.h = h; | |
| 69 if ( (SDL_EventOK == NULL) || (*SDL_EventOK)(&event) ) { | |
| 70 posted = 1; | |
| 71 SDL_PushEvent(&event); | |
| 72 } | |
| 73 } | |
| 74 return(posted); | |
| 75 } |