annotate TODO @ 4168:69bcba65c388 SDL-1.2

Fixed bug #526 Comment #1 From Simon Howard 2009-03-20 16:50:56 Hi, I'm the author of Chocolate Doom, one of the other source ports that James mentioned. This is a patch against the current SVN version of SDL 1.2 that fixes the bug. It has been tested and hopefully should be obviously correct from examining the changes. I'll give a brief explanation. When the palette is set with SDL_SetPalette, the IDirectDrawPalette_SetEntries DirectX function is invoked. However, when this happens, a WM_PALETTECHANGED message is sent to the window. A WM_PALETTECHANGED message can also be received if the palette is changed for some other reason, like if the system palette is changed. Therefore, the palette change handler (DX5_PaletteChanged) has code to deal with this case. It distinguishes "expected" palette changes (set with SDL_SetPalette) from "unexpected" palette changes using the colorchange_expected variable, which is set before calling IDirectDrawPalette_SetEntries. However, the code to set this variable is missing in the fullscreen code path. By setting this variable, the palette change is handled properly and the freezes go away.
author Sam Lantinga <slouken@libsdl.org>
date Mon, 13 Apr 2009 00:53:12 +0000
parents f12379c41042
children 0a53c90a37f9 c121d94672cb
rev   line source
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
1
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
2 Wish list for the 1.3 development branch:
1534
f02e673ffc5f *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 1441
diff changeset
3 http://bugzilla.libsdl.org/
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
4
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
5 * Add mousewheel events (new unified event architecture?)
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
6 * DirectInput joystick support needs to be implemented
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
7 * Be able to enumerate and select available audio and video drivers
1621
f12379c41042 Fixes bug #195:
Sam Lantinga <slouken@libsdl.org>
parents: 1534
diff changeset
8 * Fullscreen video mode support for Mac OS X
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
9 * Explicit vertical retrace wait (maybe separate from SDL_Flip?)
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
10 * Shaped windows, windows without borders
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
11 * Multiple windows, multiple display support
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
12 * SDL_INIT_EVENTTHREAD on Windows and MacOS?
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
13 * Add a timestamp to events
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
14 * Add audio input API
2
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
15 * Add hardware accelerated scaled blit
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
16 * Add hardware accelerated alpha blits
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
17 * Redesign blitting architecture to allow blit plugins
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
18
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
19 In the jump from 1.2 to 1.3, we should change the SDL_Rect members to
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
20 int and evaluate all the rest of the datatypes. This is the only place
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
21 we should do it though, since the 1.2 series should not break binary
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
22 compatibility in this way.
150
df1d68818edb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 2
diff changeset
23
df1d68818edb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 2
diff changeset
24 Requests:
df1d68818edb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 2
diff changeset
25 * PCM and CDROM volume control (deprecated, but possible)