Mercurial > sdl-ios-xcode
annotate test/testlock.c @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | be9c9c8f6d53 |
| children | 14717b52abc0 |
| rev | line source |
|---|---|
| 0 | 1 |
| 2 /* Test the thread and mutex locking functions | |
| 3 Also exercises the system's signal/thread interaction | |
| 4 */ | |
| 5 | |
| 6 #include <signal.h> | |
| 7 #include <stdio.h> | |
| 8 #include <stdlib.h> | |
| 9 | |
| 10 #include "SDL.h" | |
| 11 #include "SDL_mutex.h" | |
| 12 #include "SDL_thread.h" | |
| 13 | |
| 14 static SDL_mutex *mutex = NULL; | |
| 15 static Uint32 mainthread; | |
| 16 static SDL_Thread *threads[6]; | |
| 17 | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
18 /* |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
19 * SDL_Quit() shouldn't be used with atexit() directly because |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
20 * calling conventions may differ... |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
21 */ |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
22 static void SDL_Quit_Wrapper(void) |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
23 { |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
24 SDL_Quit(); |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
25 } |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
26 |
| 0 | 27 void printid(void) |
| 28 { | |
| 29 printf("Process %u: exiting\n", SDL_ThreadID()); | |
| 30 } | |
| 31 | |
| 32 void terminate(int sig) | |
| 33 { | |
| 34 printf("Process %u: raising SIGTERM\n", SDL_ThreadID()); | |
| 35 raise(SIGTERM); | |
| 36 } | |
| 37 void closemutex(int sig) | |
| 38 { | |
| 39 Uint32 id = SDL_ThreadID(); | |
| 40 int i; | |
| 41 printf("Process %u: Cleaning up...\n", id == mainthread ? 0 : id); | |
| 42 for ( i=0; i<6; ++i ) | |
| 43 SDL_KillThread(threads[i]); | |
| 44 SDL_DestroyMutex(mutex); | |
| 45 exit(sig); | |
| 46 } | |
| 47 int Run(void *data) | |
| 48 { | |
| 49 if ( SDL_ThreadID() == mainthread ) | |
| 50 signal(SIGTERM, closemutex); | |
| 51 while ( 1 ) { | |
| 52 printf("Process %u ready to work\n", SDL_ThreadID()); | |
| 53 if ( SDL_mutexP(mutex) < 0 ) { | |
| 54 fprintf(stderr, "Couldn't lock mutex: %s", SDL_GetError()); | |
| 55 exit(1); | |
| 56 } | |
| 57 printf("Process %u, working!\n", SDL_ThreadID()); | |
| 58 SDL_Delay(1*1000); | |
| 59 printf("Process %u, done!\n", SDL_ThreadID()); | |
| 60 if ( SDL_mutexV(mutex) < 0 ) { | |
| 61 fprintf(stderr, "Couldn't unlock mutex: %s", SDL_GetError()); | |
| 62 exit(1); | |
| 63 } | |
| 64 /* If this sleep isn't done, then threads may starve */ | |
| 65 SDL_Delay(10); | |
| 66 } | |
| 67 return(0); | |
| 68 } | |
| 69 | |
| 70 int main(int argc, char *argv[]) | |
| 71 { | |
| 72 int i; | |
| 73 int maxproc = 6; | |
| 74 | |
| 75 /* Load the SDL library */ | |
| 76 if ( SDL_Init(0) < 0 ) { | |
| 77 fprintf(stderr, "%s\n", SDL_GetError()); | |
| 78 exit(1); | |
| 79 } | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
80 atexit(SDL_Quit_Wrapper); |
| 0 | 81 |
| 82 if ( (mutex=SDL_CreateMutex()) == NULL ) { | |
| 83 fprintf(stderr, "Couldn't create mutex: %s\n", SDL_GetError()); | |
| 84 exit(1); | |
| 85 } | |
| 86 | |
| 87 mainthread = SDL_ThreadID(); | |
| 88 printf("Main thread: %u\n", mainthread); | |
| 89 atexit(printid); | |
| 90 for ( i=0; i<maxproc; ++i ) { | |
| 91 if ( (threads[i]=SDL_CreateThread(Run, NULL)) == NULL ) | |
| 92 fprintf(stderr, "Couldn't create thread!\n"); | |
| 93 } | |
| 94 signal(SIGINT, terminate); | |
| 95 Run(NULL); | |
| 96 | |
| 97 return(0); /* Never reached */ | |
| 98 } |