Mercurial > sdl-ios-xcode
annotate test/loopwave.c @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | be9c9c8f6d53 |
| children | 0394f8ebc42d |
| rev | line source |
|---|---|
| 0 | 1 |
| 2 /* Program to load a wave file and loop playing it using SDL sound */ | |
| 3 | |
| 4 /* loopwaves.c is much more robust in handling WAVE files -- | |
| 5 This is only for simple WAVEs | |
| 6 */ | |
| 7 | |
| 8 #include <stdio.h> | |
| 9 #include <stdlib.h> | |
| 10 #include <signal.h> | |
| 11 | |
| 12 #include "SDL.h" | |
| 13 #include "SDL_audio.h" | |
| 14 | |
| 15 struct { | |
| 16 SDL_AudioSpec spec; | |
| 17 Uint8 *sound; /* Pointer to wave data */ | |
| 18 Uint32 soundlen; /* Length of wave data */ | |
| 19 int soundpos; /* Current play position */ | |
| 20 } wave; | |
| 21 | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
22 |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
23 /* Call this instead of exit(), so we can clean up SDL: atexit() is evil. */ |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
24 static void quit(int rc) |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
25 { |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
26 SDL_Quit(); |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
27 exit(rc); |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
28 } |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
29 |
|
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
30 |
| 0 | 31 void fillerup(void *unused, Uint8 *stream, int len) |
| 32 { | |
| 33 Uint8 *waveptr; | |
| 34 int waveleft; | |
| 35 | |
| 36 /* Set up the pointers */ | |
| 37 waveptr = wave.sound + wave.soundpos; | |
| 38 waveleft = wave.soundlen - wave.soundpos; | |
| 39 | |
| 40 /* Go! */ | |
| 41 while ( waveleft <= len ) { | |
| 42 SDL_MixAudio(stream, waveptr, waveleft, SDL_MIX_MAXVOLUME); | |
| 43 stream += waveleft; | |
| 44 len -= waveleft; | |
| 45 waveptr = wave.sound; | |
| 46 waveleft = wave.soundlen; | |
| 47 wave.soundpos = 0; | |
| 48 } | |
| 49 SDL_MixAudio(stream, waveptr, len, SDL_MIX_MAXVOLUME); | |
| 50 wave.soundpos += len; | |
| 51 } | |
| 52 | |
| 53 static int done = 0; | |
| 54 void poked(int sig) | |
| 55 { | |
| 56 done = 1; | |
| 57 } | |
| 58 | |
| 59 int main(int argc, char *argv[]) | |
| 60 { | |
| 61 char name[32]; | |
| 62 | |
| 63 /* Load the SDL library */ | |
| 64 if ( SDL_Init(SDL_INIT_AUDIO) < 0 ) { | |
| 65 fprintf(stderr, "Couldn't initialize SDL: %s\n",SDL_GetError()); | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
66 return(1); |
| 0 | 67 } |
| 68 | |
| 69 if ( argv[1] == NULL ) { | |
| 70 fprintf(stderr, "Usage: %s <wavefile>\n", argv[0]); | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
71 quit(1); |
| 0 | 72 } |
| 73 | |
| 74 /* Load the wave file into memory */ | |
| 75 if ( SDL_LoadWAV(argv[1], | |
| 76 &wave.spec, &wave.sound, &wave.soundlen) == NULL ) { | |
| 77 fprintf(stderr, "Couldn't load %s: %s\n", | |
| 78 argv[1], SDL_GetError()); | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
79 quit(1); |
| 0 | 80 } |
| 81 wave.spec.callback = fillerup; | |
| 82 | |
| 83 /* Set the signals */ | |
| 84 #ifdef SIGHUP | |
| 85 signal(SIGHUP, poked); | |
| 86 #endif | |
| 87 signal(SIGINT, poked); | |
| 88 #ifdef SIGQUIT | |
| 89 signal(SIGQUIT, poked); | |
| 90 #endif | |
| 91 signal(SIGTERM, poked); | |
| 92 | |
| 93 /* Initialize fillerup() variables */ | |
| 94 if ( SDL_OpenAudio(&wave.spec, NULL) < 0 ) { | |
| 95 fprintf(stderr, "Couldn't open audio: %s\n", SDL_GetError()); | |
| 96 SDL_FreeWAV(wave.sound); | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
97 quit(2); |
| 0 | 98 } |
| 99 SDL_PauseAudio(0); | |
| 100 | |
| 101 /* Let the audio run */ | |
| 102 printf("Using audio driver: %s\n", SDL_AudioDriverName(name, 32)); | |
| 103 while ( ! done && (SDL_GetAudioStatus() == SDL_AUDIO_PLAYING) ) | |
| 104 SDL_Delay(1000); | |
| 105 | |
| 106 /* Clean up on signal */ | |
| 107 SDL_CloseAudio(); | |
| 108 SDL_FreeWAV(wave.sound); | |
|
1151
be9c9c8f6d53
Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe
Ryan C. Gordon <icculus@icculus.org>
parents:
0
diff
changeset
|
109 SDL_Quit(); |
| 0 | 110 return(0); |
| 111 } |