Mercurial > sdl-ios-xcode
annotate src/video/os2fslib/SDL_os2fslib.h @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | 173c063d4f55 |
| children | d910939febfa |
| rev | line source |
|---|---|
| 1190 | 1 /* |
| 2 SDL - Simple DirectMedia Layer | |
| 3 Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002 Sam Lantinga | |
| 4 | |
| 5 This library is free software; you can redistribute it and/or | |
| 6 modify it under the terms of the GNU Library General Public | |
| 7 License as published by the Free Software Foundation; either | |
| 8 version 2 of the License, or (at your option) any later version. | |
| 9 | |
| 10 This library is distributed in the hope that it will be useful, | |
| 11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 13 Library General Public License for more details. | |
| 14 | |
| 15 You should have received a copy of the GNU Library General Public | |
| 16 License along with this library; if not, write to the Free | |
| 17 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 18 | |
| 19 Sam Lantinga | |
| 20 slouken@libsdl.org | |
| 21 */ | |
| 22 | |
| 23 #ifndef _SDL_os2fslib_h | |
| 24 #define _SDL_os2fslib_h | |
| 25 | |
| 26 | |
| 27 // OS2 specific includes | |
| 28 #define INCL_TYPES | |
| 29 #define INCL_DOS | |
| 30 #define INCL_DOSERRORS | |
| 31 #define INCL_DOSPROCESS | |
| 32 #define INCL_WIN | |
| 33 #define INCL_GPI | |
| 34 #include <os2.h> | |
| 35 | |
| 36 #include <FSLib.h> | |
| 37 | |
| 38 /* Hidden "this" pointer for the video functions */ | |
| 39 #define _THIS SDL_VideoDevice *_this | |
| 40 | |
| 41 /* Private display data */ | |
| 42 struct SDL_PrivateVideoData | |
| 43 { | |
| 44 FSLib_VideoMode_p pAvailableFSLibVideoModes; | |
| 45 SDL_Rect **pListModesResult; // Allocated memory to return list of modes for os2fslib_ListModes() API | |
| 46 | |
| 47 FSLib_VideoMode SrcBufferDesc; // Description of current source image buffer | |
| 48 char *pchSrcBuffer; // The source image buffer itself | |
| 49 SDL_Surface *pSDLSurface; // The SDL surface describing the buffer | |
| 50 HMTX hmtxUseSrcBuffer; // Mutex semaphore to manipulate src buffer | |
| 51 HWND hwndFrame, hwndClient; // Window handle of frame and client | |
| 52 int iPMThreadStatus; // 0: Not running | |
| 53 // 1: Running | |
| 54 // Other: Not running, had an error | |
| 55 int tidPMThread; // Thread ID of PM Thread | |
| 56 int fInFocus; // True if we're in focus! | |
| 57 int iSkipWMMOUSEMOVE; // Number of WM_MOUSEMOVE messages to skip! | |
| 58 int iMouseVisible; // | |
| 59 }; | |
| 60 | |
| 61 extern DECLSPEC void SDLCALL SDL_OS2FSLIB_SetFCFToUse(ULONG ulFCF); | |
| 62 | |
| 63 #endif /* _SDL_os2fslib_h */ |