Mercurial > sdl-ios-xcode
annotate src/joystick/SDL_sysjoystick.h @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | b8d311d90021 |
| children | c9b51268668f |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 2 SDL - Simple DirectMedia Layer | |
|
769
b8d311d90021
Updated copyright information for 2004 (Happy New Year!)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
3 Copyright (C) 1997-2004 Sam Lantinga |
| 0 | 4 |
| 5 This library is free software; you can redistribute it and/or | |
| 6 modify it under the terms of the GNU Library General Public | |
| 7 License as published by the Free Software Foundation; either | |
| 8 version 2 of the License, or (at your option) any later version. | |
| 9 | |
| 10 This library is distributed in the hope that it will be useful, | |
| 11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 13 Library General Public License for more details. | |
| 14 | |
| 15 You should have received a copy of the GNU Library General Public | |
| 16 License along with this library; if not, write to the Free | |
| 17 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 18 | |
| 19 Sam Lantinga | |
|
252
e8157fcb3114
Updated the source with the correct e-mail address
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
20 slouken@libsdl.org |
| 0 | 21 */ |
| 22 | |
| 23 #ifdef SAVE_RCSID | |
| 24 static char rcsid = | |
| 25 "@(#) $Id$"; | |
| 26 #endif | |
| 27 | |
| 28 /* This is the system specific header for the SDL joystick API */ | |
| 29 | |
| 30 #include "SDL_joystick.h" | |
| 31 | |
| 32 /* The SDL joystick structure */ | |
| 33 struct _SDL_Joystick { | |
| 34 Uint8 index; /* Device index */ | |
| 35 const char *name; /* Joystick name - system dependent */ | |
| 36 | |
| 37 int naxes; /* Number of axis controls on the joystick */ | |
| 38 Sint16 *axes; /* Current axis states */ | |
| 39 | |
| 40 int nhats; /* Number of hats on the joystick */ | |
| 41 Uint8 *hats; /* Current hat states */ | |
| 42 | |
| 43 int nballs; /* Number of trackballs on the joystick */ | |
| 44 struct balldelta { | |
| 45 int dx; | |
| 46 int dy; | |
| 47 } *balls; /* Current ball motion deltas */ | |
| 48 | |
| 49 int nbuttons; /* Number of buttons on the joystick */ | |
| 50 Uint8 *buttons; /* Current button states */ | |
| 51 | |
| 52 struct joystick_hwdata *hwdata; /* Driver dependent information */ | |
| 53 | |
| 54 int ref_count; /* Reference count for multiple opens */ | |
| 55 }; | |
| 56 | |
| 57 /* Function to scan the system for joysticks. | |
| 58 * Joystick 0 should be the system default joystick. | |
| 59 * This function should return the number of available joysticks, or -1 | |
| 60 * on an unrecoverable fatal error. | |
| 61 */ | |
| 62 extern int SDL_SYS_JoystickInit(void); | |
| 63 | |
| 64 /* Function to get the device-dependent name of a joystick */ | |
| 65 extern const char *SDL_SYS_JoystickName(int index); | |
| 66 | |
| 67 /* Function to open a joystick for use. | |
| 68 The joystick to open is specified by the index field of the joystick. | |
| 69 This should fill the nbuttons and naxes fields of the joystick structure. | |
| 70 It returns 0, or -1 if there is an error. | |
| 71 */ | |
| 72 extern int SDL_SYS_JoystickOpen(SDL_Joystick *joystick); | |
| 73 | |
| 74 /* Function to update the state of a joystick - called as a device poll. | |
| 75 * This function shouldn't update the joystick structure directly, | |
| 76 * but instead should call SDL_PrivateJoystick*() to deliver events | |
| 77 * and update joystick device state. | |
| 78 */ | |
| 79 extern void SDL_SYS_JoystickUpdate(SDL_Joystick *joystick); | |
| 80 | |
| 81 /* Function to close a joystick after use */ | |
| 82 extern void SDL_SYS_JoystickClose(SDL_Joystick *joystick); | |
| 83 | |
| 84 /* Function to perform any system-specific joystick related cleanup */ | |
| 85 extern void SDL_SYS_JoystickQuit(void); | |
| 86 |