Mercurial > sdl-ios-xcode
annotate include/SDL_thread.h @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | 173c063d4f55 |
| children | c9b51268668f |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 2 SDL - Simple DirectMedia Layer | |
|
769
b8d311d90021
Updated copyright information for 2004 (Happy New Year!)
Sam Lantinga <slouken@libsdl.org>
parents:
337
diff
changeset
|
3 Copyright (C) 1997-2004 Sam Lantinga |
| 0 | 4 |
| 5 This library is free software; you can redistribute it and/or | |
| 6 modify it under the terms of the GNU Library General Public | |
| 7 License as published by the Free Software Foundation; either | |
| 8 version 2 of the License, or (at your option) any later version. | |
| 9 | |
| 10 This library is distributed in the hope that it will be useful, | |
| 11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 13 Library General Public License for more details. | |
| 14 | |
| 15 You should have received a copy of the GNU Library General Public | |
| 16 License along with this library; if not, write to the Free | |
| 17 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 18 | |
| 19 Sam Lantinga | |
|
251
b8688cfdc232
Updated the headers with the correct e-mail address
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
20 slouken@libsdl.org |
| 0 | 21 */ |
| 22 | |
| 23 #ifdef SAVE_RCSID | |
| 24 static char rcsid = | |
| 25 "@(#) $Id$"; | |
| 26 #endif | |
| 27 | |
| 28 #ifndef _SDL_thread_h | |
| 29 #define _SDL_thread_h | |
| 30 | |
| 31 /* Header for the SDL thread management routines | |
| 32 | |
| 33 These are independent of the other SDL routines. | |
| 34 */ | |
| 35 | |
| 36 #include "SDL_main.h" | |
| 37 #include "SDL_types.h" | |
| 38 | |
| 39 /* Thread synchronization primitives */ | |
| 40 #include "SDL_mutex.h" | |
| 41 | |
| 42 #include "begin_code.h" | |
| 43 /* Set up for C function definitions, even when using C++ */ | |
| 44 #ifdef __cplusplus | |
| 45 extern "C" { | |
| 46 #endif | |
| 47 | |
| 48 /* The SDL thread structure, defined in SDL_thread.c */ | |
| 49 struct SDL_Thread; | |
| 50 typedef struct SDL_Thread SDL_Thread; | |
| 51 | |
| 52 /* Create a thread */ | |
| 1190 | 53 #ifdef __OS2__ |
| 54 /* | |
| 55 We compile SDL into a DLL on OS/2. This means, that it's the DLL which | |
| 56 creates a new thread for the calling process with the SDL_CreateThread() | |
| 57 API. There is a problem with this, that only the RTL of the SDL.DLL will | |
| 58 be initialized for those threads, and not the RTL of the calling application! | |
| 59 To solve this, we make a little hack here. | |
| 60 We'll always use the caller's _beginthread() and _endthread() APIs to | |
| 61 start a new thread. This way, it it's the SDL.DLL which uses this API, | |
| 62 then the RTL of SDL.DLL will be used to create the new thread, and if it's | |
| 63 the application, then the RTL of the application will be used. | |
| 64 So, in short: | |
| 65 Always use the _beginthread() and _endthread() of the calling runtime library! | |
| 66 */ | |
| 67 | |
| 68 #ifdef __WATCOMC__ | |
| 69 #include <process.h> // This has _beginthread() and _endthread() defined! | |
| 70 #endif | |
| 71 #ifdef __EMX__ | |
| 72 #include <stdlib.h> // This has _beginthread() and _endthread() defined, if -Zmt flag is used! | |
| 73 #endif | |
| 74 | |
| 75 typedef Uint32 SDLCALL (*pfnSDL_CurrentBeginThread)(void (*pfnThreadFn)(void *), Uint32 uiStackSize, void *pParam); | |
| 76 typedef void SDLCALL (*pfnSDL_CurrentEndThread)(void); | |
| 77 | |
| 78 extern DECLSPEC SDL_Thread * SDLCALL SDL_CreateThread_Core(int (*fn)(void *), void *data, pfnSDL_CurrentBeginThread pfnBeginThread, pfnSDL_CurrentEndThread pfnEndThread); | |
| 79 | |
| 80 // Disable warnings about unreferenced symbol! | |
| 81 #pragma disable_message (202) | |
| 82 static Uint32 SDLCALL SDL_CurrentBeginThread(void (*pfnThreadFn)(void *), Uint32 uiStackSize, void *pParam) | |
| 83 { | |
| 84 return _beginthread(pfnThreadFn, NULL, uiStackSize, pParam); | |
| 85 } | |
| 86 | |
| 87 static void SDLCALL SDL_CurrentEndThread(void) | |
| 88 { | |
| 89 _endthread(); | |
| 90 } | |
| 91 | |
| 92 #define SDL_CreateThread(fn, data) SDL_CreateThread_Core(fn, data, SDL_CurrentBeginThread, SDL_CurrentEndThread) | |
| 93 | |
| 94 #else | |
|
930
02759105b989
Date: Fri, 20 Aug 2004 08:31:20 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
769
diff
changeset
|
95 extern DECLSPEC SDL_Thread * SDLCALL SDL_CreateThread(int (SDLCALL *fn)(void *), void *data); |
| 1190 | 96 #endif |
| 0 | 97 |
| 98 /* Get the 32-bit thread identifier for the current thread */ | |
|
337
9154ec9ca3d2
Explicitly specify the SDL API calling convention (C by default)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
99 extern DECLSPEC Uint32 SDLCALL SDL_ThreadID(void); |
| 0 | 100 |
| 101 /* Get the 32-bit thread identifier for the specified thread, | |
| 102 equivalent to SDL_ThreadID() if the specified thread is NULL. | |
| 103 */ | |
|
337
9154ec9ca3d2
Explicitly specify the SDL API calling convention (C by default)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
104 extern DECLSPEC Uint32 SDLCALL SDL_GetThreadID(SDL_Thread *thread); |
| 0 | 105 |
| 106 /* Wait for a thread to finish. | |
| 107 The return code for the thread function is placed in the area | |
| 108 pointed to by 'status', if 'status' is not NULL. | |
| 109 */ | |
|
337
9154ec9ca3d2
Explicitly specify the SDL API calling convention (C by default)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
110 extern DECLSPEC void SDLCALL SDL_WaitThread(SDL_Thread *thread, int *status); |
| 0 | 111 |
| 112 /* Forcefully kill a thread without worrying about its state */ | |
|
337
9154ec9ca3d2
Explicitly specify the SDL API calling convention (C by default)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
113 extern DECLSPEC void SDLCALL SDL_KillThread(SDL_Thread *thread); |
| 0 | 114 |
| 115 | |
| 116 /* Ends C function definitions when using C++ */ | |
| 117 #ifdef __cplusplus | |
| 118 } | |
| 119 #endif | |
| 120 #include "close_code.h" | |
| 121 | |
| 122 #endif /* _SDL_thread_h */ |