Mercurial > sdl-ios-xcode
annotate src/thread/win32/SDL_sysmutex.c @ 942:41a59de7f2ed
Here are patches for SDL12 and SDL_mixer for 4 or 6 channel
surround sound on Linux using the Alsa driver. To use them, naturally
you need a sound card that will do 4 or 6 channels and probably also a
recent version of the Alsa drivers and library. Since the only SDL
output driver that knows about surround sound is the Alsa driver,
you���ll want to choose it, using:
export SDL_AUDIODRIVER=alsa
There are no syntactic changes to the programming API. No new
library calls, no differences in arguments.
There are two semantic changes:
(1) For library calls with number of channels as an argument, formerly
you could use only 1 or 2 for the number of channels. Now you
can also use 4 or 6.
(2) The two "left" and "right" arguments to Mix_SetPanning, for the
case of 4 or 6 channels, no longer simply control the volumes of
the left and right channels. Now the "left" argument is converted
to an angle and Mix_SetPosition is called, and the "right" argu-
ment is ignored.
With two exceptions, so far as I know, the modified SDL12 and
SDL_mixer work the same way as the original versions, when opened for
1 or 2 channel output. The two exceptions are bugs which I fixed.
Well, the first, anyway, is a bug for sure. When rate conversions up
or down by a factor of two are applied (in src/audio/SDL_audiocvt.c),
streams with different numbers of channels (that is, mono and stereo)
are treated the same way: either each sample is copied or every other
sample is omitted. This is ok for mono, but for stereo, it is frames
that should be copied or omitted, where by "frame" I mean a portion of
the stream containing one sample for each channel. (In the SDL source,
confusingly, sometimes frames are called "samples".) So for these
rate conversions, stereo streams have to be treated differently, and
they are, in my modified version.
The other problem that might be characterized as a bug arises
when SDL_mixer is passed a multichannel chunk which does not have an
integral number of frames. Due to the way the effect_position code
loops over frames, when the chunk ends with a partial frame, memory
outside the chunk buffer will be accessed. In the case of stereo,
it���s possible that because malloc may give more memory than requested,
this potential problem never actually causes a segment fault. I don���t
know. For 6 channel chunks, I do know, and it does cause segment
faults.
If SDL_mixer is passed defective chunks and this causes a segment
fault, arguably, that���s not a bug in SDL_mixer. Still, whether or not
it counts as a bug, it���s easy to protect against, so why not? I added
code in mixer.c to discard any partial frame at the end of a chunk.
Then what about when SDL or SDL_mixer is opened for 4 or 6 chan-
nel output? What happens with the parts of the current library
designed for stereo? I don���t know whether I���ve covered all the bases,
but I���ve tried:
(1) For playing 2 channel waves, or other cases where SDL knows it has
to match up a 2 channel source with a 4 or 6 channel output, I���ve
added code in SDL_audiocvt.c to make the necessary conversions.
(2) For playing midis using timidity, I���ve converted timidity to do 4
or 6 channel output, upon request.
(3) For playing mods using mikmod, I put ad hoc code in music.c to
convert the stereo output that mikmod produces to 4 or 6 chan-
nels. Obviously it would be better to change the mikmod code to
mix down into 4 or 6 channels, but I have a hard time following
the code in mikmod, so I didn���t do that.
(4) For playing mp3s, I put ad hoc code in smpeg to copy channels in
the case when 4 or 6 channel output is needed.
(5) There seems to be no problem with .ogg files - stereo .oggs can be
up converted as .wavs are.
(6) The effect_position code in SDL_mixer is now generalized to in-
clude the cases of 4 and 6 channel streams.
I���ve done a very limited amount of compatibility testing for some
of the games using SDL I happen to have. For details, see the file
TESTS.
I���ve put into a separate archive, Surround-SDL-testfiles.tgz, a
couple of 6 channel wave files for testing and a 6 channel ogg file.
If you have the right hardware and version of Alsa, you should be able
to play the wave files with the Alsa utility aplay (and hear all
channels, except maybe lfe, for chan-id.wav, since it���s rather faint).
Don���t expect aplay to give good sound, though. There���s something
wrong with the current version of aplay.
The canyon.ogg file is to test loading of 6 channel oggs. After
patching and compiling, you can play it with playmus. (My version of
ogg123 will not play it, and I had to patch mplayer to get it to play
6 channel oggs.)
Greg Lee <greg@ling.lll.hawaii.edu>
Thus, July 1, 2004
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Sat, 21 Aug 2004 12:27:02 +0000 |
| parents | b8d311d90021 |
| children | c9b51268668f |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 2 SDL - Simple DirectMedia Layer | |
|
769
b8d311d90021
Updated copyright information for 2004 (Happy New Year!)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
3 Copyright (C) 1997-2004 Sam Lantinga |
| 0 | 4 |
| 5 This library is free software; you can redistribute it and/or | |
| 6 modify it under the terms of the GNU Library General Public | |
| 7 License as published by the Free Software Foundation; either | |
| 8 version 2 of the License, or (at your option) any later version. | |
| 9 | |
| 10 This library is distributed in the hope that it will be useful, | |
| 11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 13 Library General Public License for more details. | |
| 14 | |
| 15 You should have received a copy of the GNU Library General Public | |
| 16 License along with this library; if not, write to the Free | |
| 17 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 18 | |
| 19 Sam Lantinga | |
|
252
e8157fcb3114
Updated the source with the correct e-mail address
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
20 slouken@libsdl.org |
| 0 | 21 */ |
| 22 | |
| 23 #ifdef SAVE_RCSID | |
| 24 static char rcsid = | |
| 25 "@(#) $Id$"; | |
| 26 #endif | |
| 27 | |
| 28 /* Mutex functions using the Win32 API */ | |
| 29 | |
| 30 #include <stdio.h> | |
| 31 #include <stdlib.h> | |
| 32 #include <windows.h> | |
| 33 | |
| 34 #include "SDL_error.h" | |
| 35 #include "SDL_mutex.h" | |
| 36 | |
| 37 | |
| 38 struct SDL_mutex { | |
| 39 HANDLE id; | |
| 40 }; | |
| 41 | |
| 42 /* Create a mutex */ | |
| 43 SDL_mutex *SDL_CreateMutex(void) | |
| 44 { | |
| 45 SDL_mutex *mutex; | |
| 46 | |
| 47 /* Allocate mutex memory */ | |
| 48 mutex = (SDL_mutex *)malloc(sizeof(*mutex)); | |
| 49 if ( mutex ) { | |
| 50 /* Create the mutex, with initial value signaled */ | |
| 51 mutex->id = CreateMutex(NULL, FALSE, NULL); | |
| 52 if ( ! mutex->id ) { | |
| 53 SDL_SetError("Couldn't create mutex"); | |
| 54 free(mutex); | |
| 55 mutex = NULL; | |
| 56 } | |
| 57 } else { | |
| 58 SDL_OutOfMemory(); | |
| 59 } | |
| 60 return(mutex); | |
| 61 } | |
| 62 | |
| 63 /* Free the mutex */ | |
| 64 void SDL_DestroyMutex(SDL_mutex *mutex) | |
| 65 { | |
| 66 if ( mutex ) { | |
| 67 if ( mutex->id ) { | |
| 68 CloseHandle(mutex->id); | |
| 69 mutex->id = 0; | |
| 70 } | |
| 71 free(mutex); | |
| 72 } | |
| 73 } | |
| 74 | |
| 75 /* Lock the mutex */ | |
| 76 int SDL_mutexP(SDL_mutex *mutex) | |
| 77 { | |
| 78 if ( mutex == NULL ) { | |
| 79 SDL_SetError("Passed a NULL mutex"); | |
| 80 return -1; | |
| 81 } | |
| 82 if ( WaitForSingleObject(mutex->id, INFINITE) == WAIT_FAILED ) { | |
| 83 SDL_SetError("Couldn't wait on mutex"); | |
| 84 return -1; | |
| 85 } | |
| 86 return(0); | |
| 87 } | |
| 88 | |
| 89 /* Unlock the mutex */ | |
| 90 int SDL_mutexV(SDL_mutex *mutex) | |
| 91 { | |
| 92 if ( mutex == NULL ) { | |
| 93 SDL_SetError("Passed a NULL mutex"); | |
| 94 return -1; | |
| 95 } | |
| 96 if ( ReleaseMutex(mutex->id) == FALSE ) { | |
| 97 SDL_SetError("Couldn't release mutex"); | |
| 98 return -1; | |
| 99 } | |
| 100 return(0); | |
| 101 } |