annotate src/hermes/README @ 1348:40d0975c1769
Date: Mon, 6 Feb 2006 11:41:04 -0500
From: "mystml@adinet.com.uy"
Subject: [SDL] ALT-F4 using DirectX
My game isn't getting SDL_QUIT when I press ALT-F4 using the DirectX
driver; it does get SDL_QUIT when I press the red X in the window.
I tracked this down to DX5_HandleMessage() in SDL_dx5events.c;
WM_SYSKEYDOWN is being trapped and ignored which causes Windows not to post
a WM_CLOSE, hence no SDL_QUIT is being generated.
The relevant code is this :
/* The keyboard is handled via DirectInput */
case WM_SYSKEYUP:
case WM_SYSKEYDOWN:
case WM_KEYUP:
case WM_KEYDOWN: {
/* Ignore windows keyboard messages */;
}
return(0);
If I comment the WM_SYSKEYDOWN case, it falls through DefWindowProc() and
ALT-F4 starts working again.
I'm not sure about the best way to fix this. One option is handling ALT-F4
as a particular case somehow, but doesn't sound good. Another option would
be to handle WM_SYSKEYDOWN separately and breaking instead of returning 0,
so processing falls through and goes to DefWindowProc which does The Right
Thing (TM). This seems to be the minimal change that makes ALT-F4 work and
normal keyboard input continues to work.
Does this sound reasonable? Am I overlooking anything? Do I submit a patch?
--Gabriel
author |
Sam Lantinga <slouken@libsdl.org> |
date |
Wed, 08 Feb 2006 17:19:43 +0000 |
parents |
74212992fb08 |
children |
|
rev |
line source |
0
|
1 HERMES 1.2.4 (c)1998 Christian Nentwich (brn) (c.nentwich@cs.ucl.ac.uk)
|
|
2 and quite a few assembler routines (c) Glenn Fielder (gaffer@gaffer.org)
|
|
3
|
|
4 This library and all the files enclosed in this package are free software
|
|
5 under the terms of the GNU Library General Public License (LGPL). Please
|
|
6 refer to the included file COPYING.LIB for the exact terms.
|
|
7 ----------------------------------------------------------------------------
|
|
8
|
|
9 This is a stripped down version of HERMES, including only the x86 assembler
|
|
10 converters, for use with Simple DirectMedia Layer.
|
|
11
|
|
12 The full HERMES library is available at: http://hermes.terminal.at/
|
|
13
|