Mercurial > sdl-ios-xcode
annotate include/SDL_getenv.h @ 1524:38a12fd1a2c1
Fixed bug #46
Date: Fri, 13 Jan 2006 18:09:45 -0500
From: mhall4400 vipmail kvcc edu
Subject: Possible SDL bug
Greetings
I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM
control portion of the library.
When calling the SDL_CDPlay() function to play the last track of a CD using the
offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the
following error from a call to SDL_Error():
mciSendCommand() error: The specified parameter is out of range for the
specified command.
The code returning the error is:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
g_playingDriveSDLCD->track[trackNumberInt].length)
Subtracting one from the length of the provided length seems to repair the
problem:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
(g_playingDriveSDLCD->track[trackNumberInt].length) - 1)
Ive replicated this problem on Windows 98 SE (several months since last
patch), fully-patched Window ME, seldom-patched Windows XP SP1, and
fully-patched Windows XP SP2.
While investigating the issue, I came across a line in your librarys win32
source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive
from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add
1 to the value for length to fix MCI last track length bug. This may be the
source of the issue (because subtracting 1 from the length seems to resolve the
issue). Microsoft may have patched the referenced bug since you wrote that
line.
Mike Hall
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 14 Mar 2006 05:34:39 +0000 |
parents | 22f39393668a |
children | a1b03ba2fcd0 |
rev | line source |
---|---|
1277
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
1 /* |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
2 SDL - Simple DirectMedia Layer |
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
3 Copyright (C) 1997-2006 Sam Lantinga |
1277
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
4 |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
5 This library is free software; you can redistribute it and/or |
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
6 modify it under the terms of the GNU Lesser General Public |
1277
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
7 License as published by the Free Software Foundation; either |
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
8 version 2.1 of the License, or (at your option) any later version. |
1277
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
9 |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
10 This library is distributed in the hope that it will be useful, |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
11 but WITHOUT ANY WARRANTY; without even the implied warranty of |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
13 Lesser General Public License for more details. |
1277
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
14 |
1312
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
15 You should have received a copy of the GNU Lesser General Public |
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
16 License along with this library; if not, write to the Free Software |
c9b51268668f
Updated copyright information and removed rcs id lines (problematic in branch merges)
Sam Lantinga <slouken@libsdl.org>
parents:
1277
diff
changeset
|
17 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA |
1277
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
18 |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
19 Sam Lantinga |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
20 slouken@libsdl.org |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
21 */ |
088b806d877e
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1268
diff
changeset
|
22 |
1354
22f39393668a
Fixed build problem with SDL_string.c
Sam Lantinga <slouken@libsdl.org>
parents:
1353
diff
changeset
|
23 /* DEPRECATED */ |
1353
7ba544e2888d
Started the process of improving configure support, and merging C types
Sam Lantinga <slouken@libsdl.org>
parents:
1336
diff
changeset
|
24 #include "SDL_stdinc.h" |