Mercurial > sdl-ios-xcode
annotate src/video/ggi/SDL_ggikeys.h @ 4324:1496aa09e41e SDL-1.2
Steven Noonan to sdl
While trying to build the SDLMain.m included with SDL 1.2.14, with
#define SDL_USE_NIB_FILE 1:
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function '-[SDLMain fixMenu:withAppName:]':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122:
warning: 'sizeToFit' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function 'main':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
warning: 'poseAsClass:' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
error: 'poseAsClass:' is unavailable (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377:
warning: passing argument 2 of 'NSApplicationMain' from incompatible
pointer type
Eric Wing to Sam
I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method.
This was deprecated in Obj-C 2.0 and not retained in 64-bit.
I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that.
Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason).
Three thoughts come to mind.
1) The Info.plist has properties to control things related to the startup class and nib.
NSPrincipalClass, NSMainNibFile
Maybe principle class needs to be SDLApplication and we can delete the poseAs
2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics.
3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance):
@interface SDLApplication : NSApplication
@end
@implementation SDLApplication
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
So instead, we change this to: (warning written in mail and untested)
@interface NSApplication (SDLApplication)
- (void) terminate:(id)sender;
@end
@implementation NSApplication (SDLApplication)
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line).
Perhaps you could ask the bug reporter to try this solution (#3).
And if that fails, maybe try #1.
-Eric
Steven Noonan to Sam
The suggested change (diff below) seems to work fine.
- Steven
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Oct 2009 21:07:12 +0000 |
parents | 74212992fb08 |
children | 782fd950bd46 |
rev | line source |
---|---|
0 | 1 |
2 #define SCANCODE_ESCAPE 1 | |
3 | |
4 #define SCANCODE_1 2 | |
5 #define SCANCODE_2 3 | |
6 #define SCANCODE_3 4 | |
7 #define SCANCODE_4 5 | |
8 #define SCANCODE_5 6 | |
9 #define SCANCODE_6 7 | |
10 #define SCANCODE_7 8 | |
11 #define SCANCODE_8 9 | |
12 #define SCANCODE_9 10 | |
13 #define SCANCODE_0 11 | |
14 | |
15 #define SCANCODE_MINUS 12 | |
16 #define SCANCODE_EQUAL 13 | |
17 | |
18 #define SCANCODE_BACKSPACE 14 | |
19 #define SCANCODE_TAB 15 | |
20 | |
21 #define SCANCODE_Q 16 | |
22 #define SCANCODE_W 17 | |
23 #define SCANCODE_E 18 | |
24 #define SCANCODE_R 19 | |
25 #define SCANCODE_T 20 | |
26 #define SCANCODE_Y 21 | |
27 #define SCANCODE_U 22 | |
28 #define SCANCODE_I 23 | |
29 #define SCANCODE_O 24 | |
30 #define SCANCODE_P 25 | |
31 #define SCANCODE_BRACKET_LEFT 26 | |
32 #define SCANCODE_BRACKET_RIGHT 27 | |
33 | |
34 #define SCANCODE_ENTER 28 | |
35 | |
36 #define SCANCODE_LEFTCONTROL 29 | |
37 | |
38 #define SCANCODE_A 30 | |
39 #define SCANCODE_S 31 | |
40 #define SCANCODE_D 32 | |
41 #define SCANCODE_F 33 | |
42 #define SCANCODE_G 34 | |
43 #define SCANCODE_H 35 | |
44 #define SCANCODE_J 36 | |
45 #define SCANCODE_K 37 | |
46 #define SCANCODE_L 38 | |
47 #define SCANCODE_SEMICOLON 39 | |
48 #define SCANCODE_APOSTROPHE 40 | |
49 #define SCANCODE_GRAVE 41 | |
50 | |
51 #define SCANCODE_LEFTSHIFT 42 | |
52 #define SCANCODE_BACKSLASH 43 | |
53 | |
54 #define SCANCODE_Z 44 | |
55 #define SCANCODE_X 45 | |
56 #define SCANCODE_C 46 | |
57 #define SCANCODE_V 47 | |
58 #define SCANCODE_B 48 | |
59 #define SCANCODE_N 49 | |
60 #define SCANCODE_M 50 | |
61 #define SCANCODE_COMMA 51 | |
62 #define SCANCODE_PERIOD 52 | |
63 #define SCANCODE_SLASH 53 | |
64 | |
65 #define SCANCODE_RIGHTSHIFT 54 | |
66 #define SCANCODE_KEYPADMULTIPLY 55 | |
67 | |
68 #define SCANCODE_LEFTALT 56 | |
69 #define SCANCODE_SPACE 57 | |
70 #define SCANCODE_CAPSLOCK 58 | |
71 | |
72 #define SCANCODE_F1 59 | |
73 #define SCANCODE_F2 60 | |
74 #define SCANCODE_F3 61 | |
75 #define SCANCODE_F4 62 | |
76 #define SCANCODE_F5 63 | |
77 #define SCANCODE_F6 64 | |
78 #define SCANCODE_F7 65 | |
79 #define SCANCODE_F8 66 | |
80 #define SCANCODE_F9 67 | |
81 #define SCANCODE_F10 68 | |
82 | |
83 #define SCANCODE_NUMLOCK 69 | |
84 #define SCANCODE_SCROLLLOCK 70 | |
85 | |
86 #define SCANCODE_KEYPAD7 71 | |
87 #define SCANCODE_CURSORUPLEFT 71 | |
88 #define SCANCODE_KEYPAD8 72 | |
89 #define SCANCODE_CURSORUP 72 | |
90 #define SCANCODE_KEYPAD9 73 | |
91 #define SCANCODE_CURSORUPRIGHT 73 | |
92 #define SCANCODE_KEYPADMINUS 74 | |
93 #define SCANCODE_KEYPAD4 75 | |
94 #define SCANCODE_CURSORLEFT 75 | |
95 #define SCANCODE_KEYPAD5 76 | |
96 #define SCANCODE_KEYPAD6 77 | |
97 #define SCANCODE_CURSORRIGHT 77 | |
98 #define SCANCODE_KEYPADPLUS 78 | |
99 #define SCANCODE_KEYPAD1 79 | |
100 #define SCANCODE_CURSORDOWNLEFT 79 | |
101 #define SCANCODE_KEYPAD2 80 | |
102 #define SCANCODE_CURSORDOWN 80 | |
103 #define SCANCODE_KEYPAD3 81 | |
104 #define SCANCODE_CURSORDOWNRIGHT 81 | |
105 #define SCANCODE_KEYPAD0 82 | |
106 #define SCANCODE_KEYPADPERIOD 83 | |
107 | |
108 #define SCANCODE_LESS 86 | |
109 | |
110 #define SCANCODE_F11 87 | |
111 #define SCANCODE_F12 88 | |
112 | |
113 #define SCANCODE_KEYPADENTER 96 | |
114 #define SCANCODE_RIGHTCONTROL 97 | |
115 #define SCANCODE_CONTROL 97 | |
116 #define SCANCODE_KEYPADDIVIDE 98 | |
117 #define SCANCODE_PRINTSCREEN 99 | |
118 #define SCANCODE_RIGHTALT 100 | |
119 #define SCANCODE_BREAK 101 /* Beware: is 119 */ | |
120 #define SCANCODE_BREAK_ALTERNATIVE 119 /* on some keyboards! */ | |
121 | |
122 #define SCANCODE_HOME 102 | |
123 #define SCANCODE_CURSORBLOCKUP 90 /* Cursor key block */ | |
124 #define SCANCODE_PAGEUP 104 | |
125 #define SCANCODE_CURSORBLOCKLEFT 92 /* Cursor key block */ | |
126 #define SCANCODE_CURSORBLOCKRIGHT 94 /* Cursor key block */ | |
127 #define SCANCODE_END 107 | |
128 #define SCANCODE_CURSORBLOCKDOWN 108 /* Cursor key block */ | |
129 #define SCANCODE_PAGEDOWN 109 | |
130 #define SCANCODE_INSERT 110 | |
131 #define SCANCODE_REMOVE 111 | |
132 | |
133 #define SCANCODE_RIGHTWIN 126 | |
134 #define SCANCODE_LEFTWIN 125 | |
135 |